Content-Length: 319165 | pFad | http://github.com/WebKit/WebKit/commit/c3e93693835f3f31a9667552bc1aaf41caf8bb2d#comments

20 Fix at-font-face-descriptors.html to not expect clamped specified val… · WebKit/WebKit@c3e9369 · GitHub
Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c3e9369

Browse files
nt1mdarinadler
authored andcommittedOct 25, 2022
Fix at-font-face-descriptors.html to not expect clamped specified value for font-style
https://bugs.webkit.org/show_bug.cgi?id=246960 rdar://101517323 Reviewed by Darin Adler. css/css-fonts/variations/at-font-face-descriptors.html assumes `font-style: oblique calc(91deg)` gets serialized to `font-style: oblique 90deg` in the specified style, which should not be the case according to the spec: https://drafts.csswg.org/css-values-3/#calc-range > (Clamping is not performed on specified values.) * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html: Canonical link: https://commits.webkit.org/255943@main
1 parent a74c9a0 commit c3e9369

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ PASS font-style(valid): 'oblique' followed by zero degrees: oblique 0deg
7171
FAIL font-style(valid): 'oblique' followed by default 20deg angle: oblique 20deg assert_equals: Unexpected resulting value. expected "oblique" but got "oblique 20deg"
7272
PASS font-style(valid): 'oblique' followed by maxumum 90 degree angle: oblique 90deg
7373
PASS font-style(valid): 'oblique' followed by minimum -90 degree angle: oblique -90deg
74-
FAIL font-style(valid): 'oblique' followed by calc with out of range value (should be clamped): oblique calc(91deg) assert_equals: Unexpected resulting value. expected "oblique 90deg" but got "oblique calc(91deg)"
75-
FAIL font-style(valid): 'oblique' followed by calc with out of range value (should be clamped): oblique calc(-91deg) assert_equals: Unexpected resulting value. expected "oblique -90deg" but got "oblique calc(-91deg)"
76-
FAIL font-style(valid): 'oblique' followed by angle in radians: oblique 0rad assert_equals: Unexpected resulting value. expected "oblique 0deg" but got "oblique 0rad"
74+
PASS font-style(valid): 'oblique' followed by calc with out of range value (should be clamped): oblique calc(91deg)
75+
PASS font-style(valid): 'oblique' followed by calc with out of range value (should be clamped): oblique calc(-91deg)
76+
FAIL font-style(valid): 'oblique' followed by angle in radians: oblique 0rad assert_equals: Unexpected resulting value. expected "oblique 0deg" but got "oblique 0rad"
7777
PASS font-style(invalid): 'oblique' followed by unit-less number: oblique 20
7878
PASS font-style(invalid): 'oblique' followed by non-angle: oblique 20px
7979
PASS font-style(invalid): 'oblique' followed by non-number: oblique a

‎LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@
150150
{ value: "oblique 20deg", isValid: true, expectedValue: "oblique", description: "'oblique' followed by default 20deg angle" },
151151
{ value: "oblique 90deg", isValid: true, description: "'oblique' followed by maxumum 90 degree angle" },
152152
{ value: "oblique -90deg", isValid: true, description: "'oblique' followed by minimum -90 degree angle" },
153-
{ value: "oblique calc(91deg)", isValid: true, expectedValue: "oblique 90deg", description: "'oblique' followed by calc with out of range value (should be clamped)" },
154-
{ value: "oblique calc(-91deg)", isValid: true, expectedValue: "oblique -90deg", description: "'oblique' followed by calc with out of range value (should be clamped)" },
155-
{ value: "oblique 0rad", isValid: true, expectedValue: "oblique 0deg", description: "'oblique' followed by angle in radians" },
153+
{ value: "oblique calc(91deg)", isValid: true, description: "'oblique' followed by calc with out of range value (should be clamped)" },
154+
{ value: "oblique calc(-91deg)", isValid: true, description: "'oblique' followed by calc with out of range value (should be clamped)" },
155+
{ value: "oblique 0rad", isValid: true, expectedValue: "oblique 0deg", description: "'oblique' followed by angle in radians" },
156156
{ value: "oblique 20", isValid: false, description: "'oblique' followed by unit-less number" },
157157
{ value: "oblique 20px", isValid: false, description: "'oblique' followed by non-angle" },
158158
{ value: "oblique a", isValid: false, description: "'oblique' followed by non-number" },

0 commit comments

Comments
 (0)
Failed to load comments.








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/WebKit/WebKit/commit/c3e93693835f3f31a9667552bc1aaf41caf8bb2d#comments

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy