fix(core): avoid injecting internal error handler from a destroyed injector

arturovt · arturovt · commit 13c53f137976 · 2025-06-26T01:01:04.000+03:00
This commit prevents lazy injection of the internal `ErrorHandler` from a destroyed injector, which would otherwise result in a secondary "destroyed injector" error.

The `handleUncaughtError` function is used in a wrapped event listener that invokes the `ErrorHandler` if the listener throws. A simple case in a micro-frontend application:

```ts
onNavigationToAnotherApp() {
  this.appRef.destroy();
  do_some_stuff_ie_loggin_that_may_throw();
}
```

If the function throws an error, Angular attempts to inject the `ErrorHandler` from a destroyed injector.
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -699,7 +699,8 @@ export function handleUncaughtError(lView: LView, error: any): void {
   if (!injector) {
     return;
   }
-  const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);
+  // TODO(atscott): should we re-throw an error in a `setTimeout` if injector is destroyed?
+  const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null, {optional: true});
   errorHandler?.(error);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,8 @@ export function handleUncaughtError(lView: LView, error: any): void {`
`699`	`699`	`if (!injector) {`
`700`	`700`	`return;`
`701`	`701`	`}`
`702`		`- const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);`
	`702`	+ // TODO(atscott): should we re-throw an error in a `setTimeout` if injector is destroyed?
	`703`	`+ const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null, {optional: true});`
`703`	`704`	`errorHandler?.(error);`
`704`	`705`	`}`
`705`	`706`