Content-Length: 254085 | pFad | http://github.com/gitgitgadget/gitgitgadget/issues/2162

EC Should check pull request contents for a single patch submission automatically · Issue #2162 · gitgitgadget/gitgitgadget · GitHub
Skip to content

Should check pull request contents for a single patch submission automatically #2162

@gitster

Description

@gitster

The Welcome template has this excellent write-up on how to make your pull request:

Please make sure that either:

  • Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
  • Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

However, we often see so many single-patch submissions on the git@vger.kernel.org mailing list with a copy of the log message under the three-dash line, which is a sign that the latter point is not honored.

It should be fairly simple to auto-detect. If a pull-request consists of a single-commit branch, after removing Cc: lines, the pull request description should be empty, or you'd get a "did you really mean it? Here is what we recommend in Welcome.md file" reminder, perhaps?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: http://github.com/gitgitgadget/gitgitgadget/issues/2162

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy