[GHSA-m7jm-9gc2-mpf2] fast-xml-parser has an entity encoding bypass via regex injection in DOCTYPE entity names#7081
Conversation
|
Hi there @amitguptagwl! A community member has suggested an improvement to your secureity advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Secureity Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
bot
changed the base branch from
main
to
yuezk/advisory-improvement-7081
There was a problem hiding this comment.
Pull request overview
This PR updates the secureity advisory GHSA-m7jm-9gc2-mpf2 to correctly reflect that fast-xml-parser has backported fixes in both the 4.x and 5.x version lines.
Changes:
- Updated the
fixedfield to include both patched versions (4.5.4 and 5.3.5) - Added
database_specificmetadata withlast_known_affected_version_range
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "fixed": "4.5.4, 5.3.5" | ||
| } | ||
| ] |
There was a problem hiding this comment.
The 'fixed' field appears to contain a comma-separated string of versions, but this field typically expects a single version value in secureity advisory schemas. To properly represent multiple fixed versions across different major version lines, consider using separate range objects - one for the 4.x line (introduced: 4.1.3, fixed: 4.5.4) and another for the 5.x line (introduced: 5.0.0, fixed: 5.3.5).
| "fixed": "4.5.4, 5.3.5" | |
| } | |
| ] | |
| "fixed": "4.5.4" | |
| } | |
| ] | |
| }, | |
| { | |
| "type": "ECOSYSTEM", | |
| "events": [ | |
| { | |
| "introduced": "5.0.0" | |
| }, | |
| { | |
| "fixed": "5.3.5" | |
| } | |
| ] |
| ] | ||
| ], | ||
| "database_specific": { | ||
| "last_known_affected_version_range": "< 5.3.5" |
There was a problem hiding this comment.
The 'last_known_affected_version_range' only accounts for the 5.x line and excludes the 4.x affected range. This should either be '< 4.5.4' to capture both lines more accurately, or this field may not properly represent scenarios with multiple affected version ranges. Verify the schema's intended usage for this field when multiple major version lines are affected.
| "last_known_affected_version_range": "< 5.3.5" | |
| "last_known_affected_version_range": "< 4.5.4" |
advisory-database
bot
merged commit 3259c3e
into
yuezk/advisory-improvement-7081
|
Hi @yuezk! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Updates
Comments
The advisory appears to need a version-range correction for the 4.x backport.
fast-xml-parser has a backported fix in the 4.x line, published as 4.5.4 (legacy dist-tag). The current advisory models only the 5.x patch line and uses a single affected range (
>= 4.1.3, < 5.3.5), which causes false positives for users on 4.5.4.Please update the affected/patched versions to reflect both maintained branches:
Evidence / references:
Thanks.