gh-145349: Do not install ccache#145350
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
KowalskiThomas
changed the title
ccache
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
This PR removes unnecessary overhead 👍
sccache was proposed (#127376) before we ceasing saving the caches (#139596), so at that time, we were re-using caches.
But I don't think it matters whether we use ccache or sccache, if we're just going to throw away the caches :)
If we do reintroduce caching (via ccache or sccache or something else) then we should also retain the caches between runs, but that can be handled in that PR.
hugovk
added
needs backport to 3.13
KowalskiThomas
requested review from
AA-Turner,
ezio-melotti and
webknjaz
as code owners
|
@hugovk I see you added |
|
I think it's because the Bedevere bot resets back to an initial state: https://github.com/python/bedevere#pr-state-machine I'll just approve it again, but will wait for other input before merging :) |
|
Thanks @KowalskiThomas for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @KowalskiThomas and @hugovk, I could not cleanly backport this to |
|
Thanks! |
|
Sorry, @KowalskiThomas and @hugovk, I could not cleanly backport this to |
|
@KowalskiThomas Would you like to have a go at the backports? It might be easier to create new PRs, starting directly from Let me know if you need a hand or would like me to do it. |
5 participants
What is this PR?
Initial work on GH-145349. Still need to confirm it's OK and whatnot.