Content-Length: 344605 | pFad | http://github.com/python/cpython/pull/145641

7A Fix intermittent `test_ci_fuzz_stdlib` failures by chris-eibl · Pull Request #145641 · python/cpython · GitHub
Skip to content

Fix intermittent test_ci_fuzz_stdlib failures#145641

Merged
encukou merged 1 commit intopython:mainfrom
chris-eibl:fix_test_ci_fuzz_stdlib
Mar 9, 2026
Merged

Fix intermittent test_ci_fuzz_stdlib failures#145641
encukou merged 1 commit intopython:mainfrom
chris-eibl:fix_test_ci_fuzz_stdlib

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 8, 2026 •
edited
Loading

test_ci_fuzz_stdlib fails randomly since #145232, for example:

======================================================================
ERROR: test_ci_fuzz_stdlib (test.test_tools.test_compute_changes.TestProcessChangedFiles.test_ci_fuzz_stdlib) (p=PosixPath('Modules/tomllib'))
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_tools/test_compute_changes.py", line 57, in test_ci_fuzz_stdlib
    result = process_changed_files({f})
                                    ^
UnboundLocalError: cannot access local variable 'f' where it is not associated with a value

in #145597.

Because the LIBRARY_FUZZER_PATHS is an unordered frozenset and contains an invalid entry Modules\tomllib (#143749), it can happen that this is the first item when iterating.

Let's fail test_ci_fuzz_stdlib with an explicit error message if we detect an invalid entry.

@chris-eibl chris-eibl requested review from StanFromIreland and removed request for AA-Turner, hugovk and webknjaz March 8, 2026 19:22
@chris-eibl chris-eibl requested review from hugovk and sethmlarson March 8, 2026 19:24
chris-eibl
chris-eibl commented Mar 8, 2026
View reviewed changes
Tools/build/compute-changes.py
Path("Lib/tarfile.py"),
# tomllib
Path("Modules/tomllib/"),
Path("Lib/tomllib/"),
Copy link
Member Author

@chris-eibl chris-eibl Mar 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a new issue, but maybe reusing #143572 makes sense?

Copy link
Member

@StanFromIreland StanFromIreland Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's an internal tool, it doesn’t need a blurb/issue.

@StanFromIreland StanFromIreland changed the title fix intermittent test_ci_fuzz_stdlib failures Fix intermittent test_ci_fuzz_stdlib failures Mar 8, 2026
StanFromIreland
StanFromIreland approved these changes Mar 8, 2026
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit b446092 into python:main Mar 9, 2026
100 of 102 checks passed
@chris-eibl chris-eibl deleted the fix_test_ci_fuzz_stdlib branch March 9, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@sethmlarson sethmlarson Awaiting requested review from sethmlarson

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-eibl @StanFromIreland @encukou








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/cpython/pull/145641

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy