gh-145783: Propagate errors raised in NEW_TYPE_COMMENT #145784
Open
StanFromIreland wants to merge 2 commits intopython:mainfrom
Open
gh-145783: Propagate errors raised in NEW_TYPE_COMMENT #145784StanFromIreland wants to merge 2 commits intopython:mainfrom
NEW_TYPE_COMMENT #145784StanFromIreland wants to merge 2 commits intopython:mainfrom
Conversation
StanFromIreland
requested review from
JelleZijlstra,
lysnikolaou and
pablogsal
as code owners
| _testcapi = import_helper.import_module('_testcapi') | ||
| flags = 0x0800 | 0x1000 # PyCF_IGNORE_COOKIE | PyCF_TYPE_COMMENTS | ||
| with self.assertRaises(UnicodeDecodeError): | ||
| _testcapi.Py_CompileStringExFlags( |
Member
There was a problem hiding this comment.
Why does this need _testcapi? Was the error not reproducible with a direct call to e.g. compile()?
Member
Author
There was a problem hiding this comment.
You can't pass PyCF_IGNORE_COOKIE to compile() (or any other Python API).
>>> compile(b'a=1 # type: \x80', '<test>', 'single', flags=0x0800|0x1000)
ValueError: compile(): unrecognised flags
Since this is the function used in the fuzzer, (I hope) it may be useful for future issues found by it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEW_TYPE_COMMENT#145783