-
Notifications
You must be signed in to change notification settings - Fork 349
Call finalize and report timing
automatically on end-of-body
#1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ae15bd9
Move `finalize and report timing` to controller
noamr 1e62dff
Nits
noamr eb83a24
Maintain previous ID
noamr 07431d2
Expose resource info separately
noamr 6ba027a
Pass all parameters to conclude steps
noamr a4b1ca4
Nits, and rename some phases
noamr ee02a16
Align server-timing with conclude
noamr e570139
Note about caching
noamr dac82aa
Note about caching
noamr a1e3592
Note about caching
noamr 47d2a5c
Rename states
noamr e11d337
Unshould
noamr ac55553
Fix some CR nits
noamr dc1f604
Simplify state
noamr 2b17c8f
nits
noamr e8395c0
Dedup timing-info
noamr 4f4bc76
Refactor to auto-report timing
noamr c515af4
none-
noamr d8cc0b5
Enable nav-timing & early-hints
noamr 9a9b6cc
Explicit ID
noamr f35a7bc
nits
noamr 4bd90b1
PR nits
noamr 37e09f6
Move to own li
noamr 6af3b82
Fix PR nits
noamr 43be574
Associate initiator type with request
noamr 448f3ae
Spell out initiator-type values
noamr 53f81ca
Change normative back to note
noamr c5614de
Dedup end-of-body task
noamr ff7190c
nits
annevk 622c604
Remove leftover arg
noamr 9f0745a
Account for sync XHR
noamr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Dedup end-of-body task
- Loading branch information
commit c5614debf15d979a27a22371afb192bb58c29fb1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to give only one argument ("global") to
report timing steps
, right?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, removed extra arg, good catch