Content-Length: 335608 | pFad | http://github.com/whatwg/fetch/pull/1413/commits/c5614debf15d979a27a22371afb192bb58c29fb1

9D Call `finalize and report timing` automatically on end-of-body by noamr · Pull Request #1413 · whatwg/fetch · GitHub
Skip to content

Call finalize and report timing automatically on end-of-body #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 17, 2022
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dedup end-of-body task
  • Loading branch information
noamr committed Jun 14, 2022
commit c5614debf15d979a27a22371afb192bb58c29fb1
35 changes: 20 additions & 15 deletions fetch.bs
Original file line number Diff line number Diff line change
@@ -4344,9 +4344,6 @@ steps:
<ol>
<li><p>Let <var>unsafeEndTime</var> be the <a>unsafe shared current time</a>.

<li><p>Set <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for=request>done flag</a>.

<li><p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for=request>destination</a> is "<code>document</code>", then set <var>fetchParams</var>'s
<a for="fetch params">controller</a>'s <a for="fetch controller">full timing info</a> to
@@ -4385,20 +4382,28 @@ steps:
<var>bodyInfo</var>.
</ol>

<li><p>Let <var>client</var> be <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for=request>client</a>.
<li>
<p>Let <var>processResponseEndOfBodyTask</var> be the following steps:

<li><p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for="request">initiator type</a> is not null and <var>client</var> is not null, then
<a>queue a fetch task</a> to run <var>fetchParams</var>'s <a for="fetch params">controller</a>'s
<a for="fetch controller">report timing steps</a> given <var>client</var>'s
<a for="environment settings object">global object</a> and <a for="fetch params">request</a>'s
<a for="request">initiator type</a>, with <var>client</var>'s
<a for="environment settings object">global object</a>.
<ol>
<li><p>If <var>fetchParams</var>'s <a for="fetch params">process response end-of-body</a> is
not null, then call <var>fetchParams</var>'s
<a for="fetch params">process response end-of-body</a> given <var>response</var>.

<li><p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for="request">initiator type</a> is not null and <var>fetchParams</var>'s
<a for="fetch params">request</a>'s <a for=request>client</a> is not null, then
run <var>fetchParams</var>'s <a for="fetch params">controller</a>'s
<a for="fetch controller">report timing steps</a> given <var>fetchParams</var>'s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to give only one argument ("global") to report timing steps, right?

Copy link
Contributor Author

@noamr noamr Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, removed extra arg, good catch

<a for="fetch params">request</a>'s <a for=request>client</a>'s
<a for="environment settings object">global object</a> and <a for="fetch params">request</a>'s
<a for="request">initiator type</a>.

<li><p>Set <var>fetchParams</var>'s <a for="fetch params">request</a>'s
<a for=request>done flag</a>.
</ol>

<li><p>If <var>fetchParams</var>'s <a for="fetch params">process response end-of-body</a> is not
null, then <a>queue a fetch task</a> to run <var>fetchParams</var>'s
<a for="fetch params">process response end-of-body</a> given <var>response</var> with
<li><p><a>Queue a fetch task</a> to run <var>processResponseEndOfBodyTask</var> with
<var>fetchParams</var>'s <a for="fetch params">task destination</a>.
</ol>
</li>








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/whatwg/fetch/pull/1413/commits/c5614debf15d979a27a22371afb192bb58c29fb1

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy