refactor(core): Support Error like object for resource errors. #62111
Conversation
Error like object will be treated as errors. Related to angular#61861
JeanMeche
force-pushed
the
resource/error-like
branch
from
2ad49e7 to
63e3d23
Compare
JeanMeche
changed the title
| export function isErrorLike(error: unknown): error is Error { | ||
| return ( | ||
| error instanceof Error || | ||
| (typeof error === 'object' && error !== null && 'message' in error && 'name' in error) |
There was a problem hiding this comment.
Should the fix be instead to update this http error to properly extend Error?
There was a problem hiding this comment.
HttpErrorResponse already extends another class.
angular/packages/common/http/src/response.ts
Line 339 in a40abf0
I think the change I'm suggesting has a much lower impact as we're already on the error code path.
There was a problem hiding this comment.
I will defer to others. I don't have full context on why the encapsulation exists— but it sounds like the encapsulation tries to ensure it's an Error, and this treats error-like objects as such, even though they aren't necessarily fully satisfying Error.
There was a problem hiding this comment.
Prefacing this with: I'm not on the Angular team, but this is blocking an experimental branch of mine that prepares for the Angular 20 update (and beyond) - so I tried to dig around in what is publicly available. I hope my involvement on this issue is not too egregious.
"I don't have full context on why the encapsulation exists"
It seems as though the reason is of subjective nature.
Maybe @alxhub could shed some light on this?
Error like objects will be treated as errors.
Related to #61861