Content-Length: 285697 | pFad | https://github.com/bbcmicrobit/PythonEditor/pull/289

3D Catch connection error by microbit-sam · Pull Request #289 · bbcmicrobit/PythonEditor · GitHub
Skip to content

Catch connection error #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 31, 2019
Merged

Catch connection error #289

merged 8 commits into from
Oct 31, 2019

Conversation

microbit-sam
Copy link
Collaborator

If the micro:bit takes 5 seconds to connect before flashing, assume somethings gone wrong and error out

  • 5 seconds may be too short/long?
  • What error should we use?

@microbit-carlos
Copy link
Collaborator

Updated the error to show pass the right error message and display the "reconnect micro:bit" text on the modal as well.
Event message becomes timeout-error/unable-to-connect-to-the-micro-bit.
image

@microbit-carlos microbit-carlos merged commit 0530716 into master Oct 31, 2019
@microbit-carlos microbit-carlos deleted the fix-endless-flash branch October 31, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/bbcmicrobit/PythonEditor/pull/289

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy