Content-Length: 250167 | pFad | https://github.com/bbcmicrobit/PythonEditor/pull/298

41 Fix issue downloading Python Script in Safari. by microbit-carlos · Pull Request #298 · bbcmicrobit/PythonEditor · GitHub
Skip to content

Fix issue downloading Python Script in Safari. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

microbit-carlos
Copy link
Collaborator

It also only limits the "safari bug" workaround to only execute in Safari < v10.

It also only shows the "safari bug" alert message in versions of
Safari lower than v10.
@microbit-carlos
Copy link
Collaborator Author

@microbit-josephine could you test this in macOS Safari 6, 9 and 10, and Windows IE10?

To test this PR we need to do 3 things:

  • Click on the Download buttons and verify the downloaded hex file is correct (looks like a normal hex file, as opposed to text or random numbers)
  • In the Loda/Save modal click the the "Download Project Hex" button and confirm the hex file is correct
  • In the Loda/Save modal click the the "Download Python Script" button and confirm the Python file is correct

Apart from that in Safari 6 and and 9 (but not in Safari 10!) I expect this alert to show up the file default name not to be the project name (it'll be something like "unknown" or "untitled" instead of "microbit_program"). However, the file contents should still be correct:

image

@microbit-josephine
Copy link
Contributor

There were limitations to what I could check, as I couldn't open the files in safari to check them. However, the warning messages did come up for safari 9 and 6 and the files were saved as unknown. The warning didn't appear for safari 10 or IE10 and they were named microbit_program. For IE10 the files opened fine and as expected.

@microbit-carlos
Copy link
Collaborator Author

Thanks Josephine, I've forced the download with the alert in Safari 13 via debugger and confirm that the files work using that method.

@microbit-carlos microbit-carlos merged commit 495936c into master Nov 5, 2019
@microbit-carlos microbit-carlos deleted the py_safari branch November 5, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/bbcmicrobit/PythonEditor/pull/298

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy