Content-Length: 258140 | pFad | https://github.com/bbcmicrobit/PythonEditor/pull/314

4D WebUSB: Focus the serial termianl when REPL button is pressed. by microbit-carlos · Pull Request #314 · bbcmicrobit/PythonEditor · GitHub
Skip to content

WebUSB: Focus the serial termianl when REPL button is pressed. #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

microbit-carlos
Copy link
Collaborator

This saves the user having to then click on the terminal panel.

It also moves the REPL and reset click listeners to only be initialised when WebUSB is available.
Doesn't make much of a difference, but at least it keep the WebUSB init code closer together.

This saves the user having to then click on the terminal panel.
Copy link
Collaborator

@microbit-sam microbit-sam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@microbit-carlos microbit-carlos merged commit f8dd39e into master Dec 23, 2019
@microbit-carlos
Copy link
Collaborator Author

Thanks Sam!

@microbit-carlos microbit-carlos deleted the repl-focus branch December 23, 2019 15:19
@microbit-carlos microbit-carlos self-assigned this Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/bbcmicrobit/PythonEditor/pull/314

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy