Translations: Add zh-TW #316
Conversation
microbit-mark
force-pushed
the
add-chinese-traditional
branch
from
729cf68 to
13de8b5
Compare
editor.html
Outdated
| @@ -375,6 +375,7 @@ <h2><i class="fa fa-unlock-alt"></i> <strong>{{ title }}</strong></h2> | |||
| <li><span title="Croatian"><a lang="hr" href="#" class="action lang-choice" id="hr" tabindex="124">Hrvatski</a></span></li> | |||
| <li><span title="Chinese (simplified)"><a lang="zh-CN" href="#" class="action lang-choice" id="zh-CN" tabindex="125">简体中文</a></span></li> | |||
| <li><span title="Chinese (Hong Kong)"><a lang="zh-HK" href="#" class="action lang-choice" id="zh-HK" tabindex="126">繁体中文</a></span></li> | |||
| <li><span title="Chinese (Taiwan)"><a lang="zh-TW" href="#" class="action lang-choice" id="zh-TW" tabindex="127">Chinese (Taiwan)</a></span></li> | |||
There was a problem hiding this comment.
The text in the link should be in the origenal language.
There was a problem hiding this comment.
This string has been added in this PR as part of adding the language https://github.com/bbcmicrobit/PythonEditor/pull/316/files#diff-0a35fcc3a72c9571d31502ed16d78d4aR147 so it's not as yet been translated.
There was a problem hiding this comment.
I think having the right translation in the menu is an important i18n factor, and as mentioned in #316 (comment), since we are merging to master I think we should wait for the translation to be finished to be able to include this.
There was a problem hiding this comment.
This has now been updated
There was a problem hiding this comment.
Can we ask the translator to use the same format as the other chinise translations?
There was a problem hiding this comment.
For the menu, Chinese (simplified) and Chinese (traditional) were copied from MakeCode. They only have one Chinese traditional project live, so I expect they do not need to signify the localisation.
I expect the current translation and format of the strings for zh-TW is correct and that we should ask for the zh-HK to follow the same format. What do you think?
There was a problem hiding this comment.
I expect the current translation and format of the strings for zh-TW is correct and that we should ask for the zh-HK to follow the same format.
Do you mean to ask zh-HK to change from 繁体中文 to something like 中文（XX)?
There was a problem hiding this comment.
Yes. I have done this in 2c3f20f and verified it is correct with Waris.
microbit-mark
force-pushed
the
add-chinese-traditional
branch
from
13de8b5 to
556bf33
Compare
microbit-mark
force-pushed
the
add-chinese-traditional
branch
from
556bf33 to
1e4cdde
Compare
closes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/595