Content-Length: 237716 | pFad | https://github.com/bbcmicrobit/PythonEditor/pull/317

DC Delete titles on error modal links by microbit-josephine · Pull Request #317 · bbcmicrobit/PythonEditor · GitHub
Skip to content

Delete titles on error modal links #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

microbit-josephine
Copy link
Contributor

Although there was no explicit 'title' attribute before, the 'connect to the micro:bit' title from the 'connect' div (parent) was sometimes (temperamentally) showing up. In order to erase the chance of this happening, I have set the titles to nothing.

Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all LGTM 👍
Thanks Josephine!

@microbit-carlos microbit-carlos merged commit 0270cf7 into bbcmicrobit:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/bbcmicrobit/PythonEditor/pull/317

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy