Make nil items return as None

ncw · ncw · commit f993dc7bd271 · 2014-11-24T19:09:02.000Z
diff --git a/ast/dump.go b/ast/dump.go
@@ -9,6 +9,9 @@ import (
 )
 
 func dumpItem(v interface{}) string {
+	if v == nil {
+		return "None"
+	}
 	switch x := v.(type) {
 	case py.String:
 		return fmt.Sprintf("'%s'", string(x))
diff --git a/ast/dump_test.go b/ast/dump_test.go
@@ -25,7 +25,7 @@ func TestDump(t *testing.T) {
 		{&Name{Id: Identifier("hello"), Ctx: Load}, `Name(id='hello', ctx=Load())`},
 		{&ListComp{Elt: &Str{S: py.String("potato")}, Generators: []Comprehension{{
 			Target: &Name{Id: Identifier("hello"), Ctx: Load},
-		}}}, `ListComp(elt=Str(s='potato'), generators=[comprehension(target=Name(id='hello', ctx=Load()), iter=<nil>, ifs=[])])`},
+		}}}, `ListComp(elt=Str(s='potato'), generators=[comprehension(target=Name(id='hello', ctx=Load()), iter=None, ifs=[])])`},
 	} {
 		out := Dump(test.in)
 		if out != test.out {

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,9 @@ import (`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`func dumpItem(v interface{}) string {`
	`12`	`+ if v == nil {`
	`13`	`+ return "None"`
	`14`	`+ }`
`12`	`15`	`switch x := v.(type) {`
`13`	`16`	`case py.String:`
`14`	`17`	`return fmt.Sprintf("'%s'", string(x))`