WeakMap and WeakSet#162
Merged
tarasyyyk merged 17 commits intojavascript-tutorial:masterfrom Aug 3, 2021
Merged
Conversation
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md
Outdated
Show resolved
Hide resolved
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md
Outdated
Show resolved
Hide resolved
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md
Outdated
Show resolved
Hide resolved
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md
Outdated
Show resolved
Hide resolved
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md
Outdated
Show resolved
Hide resolved
tarasyyyk
reviewed
Jul 29, 2021
1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md
Outdated
Show resolved
Hide resolved
tarasyyyk
requested changes
Jul 29, 2021
Collaborator
tarasyyyk
left a comment
tarasyyyk
left a comment
There was a problem hiding this comment.
Дуже добре. Є декілька невеличких правок. Я вже додав пропозиції, тож залишилося лише їх закомітити. На рахунок назв методів. Про це не переймайтеся – пізніше в англійському варіанті їх заберуть і я оновлю переклад.
Contributor
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
Co-authored-by: Taras <oster.ok@gmail.com>
…pt.info into weakmap-weakset
Collaborator
Author
|
@tarasyyyk дякую за правки! Я їх закомітив + додав ще пару невеликих фіксів. Сподіваюсь тепер все ок) |
Collaborator
Author
|
/done |
Collaborator
|
@MykolaSopiha чудово! Вибачте за затримку. Зараз в мене обмаль часу на перевірки. |
tarasyyyk
approved these changes
Aug 3, 2021
Contributor
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Під час перекладу помітив, що інколи назви методів перелічуються в тексті з дужками, а іноді ні. Навіть в одному і тому ж реченні. Можливо це слід обговорити та прийти до єдиного стандарту. Поки що перекладав згідно з оригіналом:
