Conversation
ghost
mhegazy
reviewed
Jun 1, 2018
src/services/services.ts
Outdated
| return true; | ||
| } | ||
|
|
||
| function getAutoCloseTagAtPosition(fileName: string, position: number): string | undefined { |
Contributor
There was a problem hiding this comment.
i would make the return type an object with a newText: string property to allow us to add more info as we need in the future.
mhegazy
reviewed
Jun 1, 2018
src/services/types.ts
Outdated
| getDocCommentTemplateAtPosition(fileName: string, position: number): TextInsertion | undefined; | ||
|
|
||
| isValidBraceCompletionAtPosition(fileName: string, position: number, openingBrace: number): boolean; | ||
| getAutoCloseTagAtPosition(fileName: string, position: number): string | undefined; |
Contributor
There was a problem hiding this comment.
i would rather this had JSX in the name.. like getJSXClosingTagAtPosition also we need to add a comment on it when it should be called.
mhegazy
approved these changes
Jun 3, 2018
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20811
The editor can call this service to get closing text for the current tag, or
undefinedif not currently in a position to close a tag (or tag already closed).