gh-100538: Create a workflow for verifying bundled libexpat files#100539
Closed
illia-v wants to merge 4 commits intopython:mainfrom
Closed
gh-100538: Create a workflow for verifying bundled libexpat files#100539illia-v wants to merge 4 commits intopython:mainfrom
illia-v wants to merge 4 commits intopython:mainfrom
Conversation
Member
|
You don't need news for build tools :) |
Contributor
Author
|
@sobolevn I removed the news entry |
picnixz
reviewed
Oct 4, 2025
| @@ -1,3 +1,7 @@ | |||
| /* Namespace external symbols to allow multiple libexpat version to | |||
Member
There was a problem hiding this comment.
This one is should not be needed. It's already included below.
Member
|
More generally, I'm not sure we actually need this step. Aren't we already doing this with SBOM checks? |
Member
We aren't verifying that the files in the repository are the same as the ones in the release. |
Member
|
I propose a simpler alternative: #145359 |
Member
|
closing as the alternative PR merged. thanks though, this is a useful thing for us to have! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags of libexpat releases are signed and GitHub runs a verification process on them.
I added a check of the verification status retrieved via GitHub's API. If the check succeeds, the script downloads a release source code and compares content of bundled files to the source.
Since a few lines are added to
Modules/expat/expat_external.h, I moved them to the top of the file and the script skips them.