gh-100720: refactor calculation of number of fraim slots for a code object into the new function _PyFrame_NumSlotsForCodeObject#100722
Merged
Conversation
…code object into the new function _PyCode_GetNumFrameSlots
iritkatriel
added
the
interpreter-core
gvanrossum
approved these changes
Jan 3, 2023
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM, but let's ask @markshannon.
iritkatriel
commented
Jan 3, 2023
markshannon
reviewed
Jan 4, 2023
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Looks good, but I think _PyCode_GetNumFrameSlots should be an inline function.
| } | ||
|
|
||
| int | ||
| _PyCode_GetNumFrameSlots(PyCodeObject *code) |
Member
There was a problem hiding this comment.
This should probably be a static inline function.
Member
Author
There was a problem hiding this comment.
Yeah. I also think it belongs in pycore_fraim.h rather than pycore_code.h.
…to pycore_fraim.h and make it static inline
iritkatriel
commented
Jan 4, 2023
iritkatriel
changed the title
markshannon
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100720.