[3.12] gh-118507 : Fix ntpath.isfile for pipes.#119381
Merged
zooba merged 5 commits intopython:3.12from May 22, 2024
Merged
Conversation
…r other cases (pythonGH-118755)
This was referenced May 22, 2024
Contributor
Author
|
I think I didn't include unrelated changes. Is it fine to use the C version for |
nineteendo
changed the title
nt._path_is* (GH-118755)nt._path_is* to improve applicability for other cases (GH-118755)
Member
Let's revert those, just to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident. |
Contributor
Author
|
Done, I also removed the C implementation for these functions to not give anyone ideas... |
nineteendo
changed the title
nt._path_is* to improve applicability for other cases (GH-118755)ntpath.isfile for pipes.
Member
|
A draft pull request is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nt._path_is*&nt._path_[l]exists#118507