gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call#122362
Merged
sobolevn merged 2 commits intopython:mainfrom Jul 27, 2024
Merged
gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call#122362sobolevn merged 2 commits intopython:mainfrom
PyUnicodeWriter_* API in constevaluator_call#122362sobolevn merged 2 commits intopython:mainfrom
Conversation
picnixz
reviewed
Jul 27, 2024
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?
JelleZijlstra
approved these changes
Jul 27, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, thought I got all the warnings.
Member
Author
Oups, sorry, @picnixz, I missed this question! |
Member
|
No worry (I also don't think it matters (I didn't know in which context it was being used actually)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyUnicodeWriter*is passed wherePyUnicodeWriter*is expected #122361