gh-137477: Extend regex pattern check in inspect.findsource#137479
Closed
George-Ogden wants to merge 2 commits into
Closed
gh-137477: Extend regex pattern check in inspect.findsource#137479George-Ogden wants to merge 2 commits into
inspect.findsource#137479George-Ogden wants to merge 2 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
StanFromIreland
changed the title
inspect.findsourceinspect.findsource
Member
|
Thank you for your report and PR, @George-Ogden, but I think that #137488 is more correct solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reintroduces the regex removed in #117025 with an additional case for classes.
While this is still a more hacky solution than AST parsing, etc, it handles class definitions and edge cases where the source code line is incorrect (generator bytecode).
inspect.getsourcelines()mishandles multi-line generator expressions #137477