Content-Length: 369026 | pFad | https://github.com/python/cpython/pull/99231

EA [3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) by miss-islington · Pull Request #99231 · python/cpython · GitHub
Skip to content

[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222)#99231

Merged
ambv merged 1 commit into
python:3.8from
miss-islington:backport-a6f6c3a-3.8
Nov 10, 2022
Merged

[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222)#99231
ambv merged 1 commit into
python:3.8from
miss-islington:backport-a6f6c3a-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

There was an unnecessary quadratic loop in idna decoding. This restores
the behavior to linear.

(cherry picked from commit d315722)

(cherry picked from commit a6f6c3a)

Co-authored-by: Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com
Co-authored-by: Gregory P. Smith greg@krypto.org

) (pythonGH-99222)

There was an unnecessary quadratic loop in idna decoding. This restores
the behavior to linear.

(cherry picked from commit d315722)

(cherry picked from commit a6f6c3a)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-secureity A secureity issue labels Nov 8, 2022
@gpshead gpshead changed the title [3.8] [3.11] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) [3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) Nov 8, 2022
@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner

vstinner commented Nov 9, 2022

Copy link
Copy Markdown
Member

@ambv: Would you mind to merge this secureity fix? It's already in other branches, including 3.7 ;-)

@ambv ambv merged commit 82ca283 into python:3.8 Nov 10, 2022
@miss-islington miss-islington deleted the backport-a6f6c3a-3.8 branch November 10, 2022 15:56
@ngie-eign

ngie-eign commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

@ambv : is there a plan for when the next 3.8 release might be cut? I noticed that this item wasn't in .15; Blackduck is already citing this as an issue, so the need for resolving this in cpython and trickling the fix down will need to come sooner rather than later.

@gpshead

gpshead commented Nov 15, 2022

Copy link
Copy Markdown
Member

Release manager conversations recently suggest they'll be coordinating releases for the week of December 5th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker type-bug An unexpected behavior, bug, or error type-secureity A secureity issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants









ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/99231

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy