Implement writing the __cause__ attribute on exceptions#287
Merged
Conversation
Contributor
|
No tests? :) |
Member
Author
|
That's why it reads "WIP" ;) |
filmor
changed the title
Member
Author
|
Tests added, could someone comment on whether the |
filmor
changed the title
Contributor
|
@filmor you can always stress-test for memory growth of this exception in a for-loop. Looks like it is NOT needed to call XIncref like in this case: pythonnet/src/runtime/pyobject.cs Line 79 in 86937bb Note that PyObject(IntPtr tp) constructor does not incref the ref. count. |
Member
Author
|
@denfromufa @vmuriart @tonyroberts Please review. |
Contributor
|
I don't think an incref is necessary as the CLRObject constructor creates a new python object (so reference count of 1) and never decrefs it. |
Member
Author
|
Yep, changed that already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.