Conversation
Member
Author
|
The linter failure seems like it's maybe a bug in its exclusion rules? Do |
Contributor
They may or may not have a bunch of code in them, so yes. |
ptomato
added
needs review
awaiting stage 2.7
Ms2ger
approved these changes
Mar 4, 2026
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Richard volunteered to review this, so perhaps wait for him, but it looks good to me.
Member
Author
|
The proposal has now advanced to Stage 3. |
Contributor
|
@jugglinmike can you look at the lint failure? |
test/language/expressions/dynamic-import/import-attributes/2nd-param-with-type-text.js
Outdated
Show resolved
Hide resolved
test/language/import/import-attributes/text-javascript_FIXTURE.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
approved these changes
Mar 12, 2026
Ms2ger
approved these changes
Mar 13, 2026
trflynn89
reviewed
Mar 16, 2026
| features: [import-attributes, import-text] | ||
| ---*/ | ||
|
|
||
| import value from './text-valid_FIXTURE' with { type: 'text' }; |
Contributor
There was a problem hiding this comment.
Was this meant to be ./text-empty_FIXTURE?
Member
Author
There was a problem hiding this comment.
D'oh, yes. Thanks for catching that. I'll file a PR for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filing initially as a draft, as these tests are for the Import Text proposal, which is currently at Stage 0.