fix: fsp.rm removing files does not take effect (#16032)

btea · web-flow · commit b05c405f6884 · 2024-04-05T14:39:00.000Z
diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts
@@ -504,9 +504,12 @@ export function runOptimizeDeps(
       // No need to wait, we can clean up in the background because temp folders
       // are unique per run
       debug?.(colors.green(`removing cache dir ${processingCacheDir}`))
-      fsp.rm(processingCacheDir, { recursive: true, force: true }).catch(() => {
+      try {
+        // When exiting the process, `fsp.rm` may not take effect, so we use `fs.rmSync`
+        fs.rmSync(processingCacheDir, { recursive: true, force: true })
+      } catch (error) {
         // Ignore errors
-      })
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -504,9 +504,12 @@ export function runOptimizeDeps(`
`504`	`504`	`// No need to wait, we can clean up in the background because temp folders`
`505`	`505`	`// are unique per run`
`506`	`506`	debug?.(colors.green(`removing cache dir ${processingCacheDir}`))
`507`		`- fsp.rm(processingCacheDir, { recursive: true, force: true }).catch(() => {`
	`507`	`+ try {`
	`508`	+ // When exiting the process, `fsp.rm` may not take effect, so we use `fs.rmSync`
	`509`	`+ fs.rmSync(processingCacheDir, { recursive: true, force: true })`
	`510`	`+ } catch (error) {`
`508`	`511`	`// Ignore errors`
`509`		`- })`
	`512`	`+ }`
`510`	`513`	`}`
`511`	`514`	`}`
`512`	`515`