pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: https://github.com/go-python/gpython/pull/47

abb27f2d0.css" /> py: Implement range M__getitem__ by corona10 · Pull Request #47 · go-python/gpython · GitHub
Skip to content

py: Implement range M__getitem__#47

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-46
Jan 3, 2019
Merged

py: Implement range M__getitem__#47
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-46

Conversation

@corona10
Copy link
Copy Markdown
Collaborator

@corona10 corona10 commented Jan 1, 2019

Fixes: #46

@corona10 corona10 requested a review from a team January 1, 2019 05:53
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 1, 2019 •
edited
Loading

Codecov Report

Merging #47 into master will increase coverage by 0.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   65.95%   65.96%   +0.01%     
==========================================
  Files          57       57              
  Lines       10208    10223      +15     
==========================================
+ Hits         6733     6744      +11     
- Misses       3002     3004       +2     
- Partials      473      475       +2
Impacted Files Coverage Δ
py/range.go 80.24% <73.33%> (-1.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c140988...0cf77c6. Read the comment docs.

@corona10
Copy link
Copy Markdown
Collaborator Author

corona10 commented Jan 2, 2019

@ncw PTAL

@ncw
Copy link
Copy Markdown
Collaborator

ncw commented Jan 3, 2019

Looks perfect - well done :-)

@ncw ncw merged commit 9985b49 into go-python:master Jan 3, 2019
@corona10 corona10 deleted the gh-46 branch January 4, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10 @codecov-io @ncw
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy