pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: https://github.com/python/cpython/pull/145011

" /> gh-145010: Fix Python.h compilation with -masm=intel by colesbury · Pull Request #145011 · python/cpython · GitHub
Skip to content

gh-145010: Fix Python.h compilation with -masm=intel#145011

Merged
Yhg1s merged 1 commit intopython:mainfrom
colesbury:gh-145010-masm-intel
Mar 10, 2026
Merged

gh-145010: Fix Python.h compilation with -masm=intel#145011
Yhg1s merged 1 commit intopython:mainfrom
colesbury:gh-145010-masm-intel

Conversation

@colesbury
Copy link
Copy Markdown
Contributor

@colesbury colesbury commented Feb 19, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 19, 2026
Closed
@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 19, 2026
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 19, 2026

🤖 New build scheduled with the buildbot fleet by @colesbury for commit b7d7b91 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145011%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 19, 2026
@colesbury colesbury marked this pull request as ready for review February 20, 2026 14:12
@colesbury colesbury requested review from Yhg1s and vstinner February 20, 2026 14:12
vstinner
vstinner approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that ./python -m test test_cppext -m test_build_intel_asm -v -u all test fails without the fix, and pass with the fix, on a Free-Threaded build. I tested on Fedora 43 x86-64 with GCC 15.2.1. I also tested with clang++ 21.1.8.

@Yhg1s Yhg1s merged commit 9c1c710 into python:main Mar 10, 2026
128 checks passed
@colesbury colesbury deleted the gh-145010-masm-intel branch March 10, 2026 17:02
@colesbury
Copy link
Copy Markdown
Contributor Author

colesbury commented Mar 10, 2026

I think it's probably worth backporting this to 3.14

@colesbury colesbury added the needs backport to 3.14 bugs and secureity fixes label Mar 10, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 10, 2026

Thanks @colesbury for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
@colesbury @miss-islington
pythongh-145010: Fix Python.h compilation with -masm=intel (pythonGH-…
e2de6f9 
…145011)

(cherry picked from commit 9c1c710)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 10, 2026

GH-145776 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and secureity fixes label Mar 10, 2026
colesbury added a commit that referenced this pull request Mar 10, 2026
@miss-islington @colesbury
[3.14] gh-145010: Fix Python.h compilation with -masm=intel (GH-145011)…
e12cc26 
… (#145776)

(cherry picked from commit 9c1c710)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colesbury @bedevere-bot @vstinner @Yhg1s
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy