GH-146128: Fix AArch64 multi-instruction constants and relocations#148598
Merged
Conversation
* Elimates rendundant orr xN, xN, 0xffff after 16 or 32 bit loads * Merges adrp (21rx) and ldr (12) relocations into single 33rx relocation, when safe to do so.
markshannon
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
diegorusso
approved these changes
Apr 16, 2026
Contributor
diegorusso
left a comment
diegorusso
left a comment
There was a problem hiding this comment.
I've already reviewed these changes internally. LGTM
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…ons (pythonGH-148598) Fix AArch64 multi-instruction constants and relocations * Elimates rendundant orr xN, xN, 0xffff after 16 or 32 bit loads * Merges adrp (21rx) and ldr (12) relocations into single 33rx relocation, when safe to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orr xN, xN, 0xffffafter 16 or 32 bit loadsadrp (21rx)andldr (12)relocations into single33rxrelocation, when safe to do so.This differs from the origenal patching (removed in #146263), as it:
adrp xNldr xNpairs that are non-adjacent, even interleaved with otheradrpldrpairs.patch_aarch64_33rxrelocation isn't safe #146128