Content-Length: 278710 | pFad | http://github.com/microsoft/TypeScript/pull/62300/commits/de914f6a47826470fdb73635f782f09a75d86d35

2B Consistently error on attempts to access private properties on generic objects by Andarist · Pull Request #62300 · microsoft/TypeScript · GitHub
Skip to content

Consistently error on attempts to access private properties on generic objects #62300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1,674 −10
Open

Consistently error on attempts to access private properties on generic objects #62300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
020ad07
Consistently error on attempts to access private properties on generi…
Andarist Aug 18, 2025
de914f6
only report the error on `IndexedAccessType` nodes
Andarist Aug 18, 2025
28d83f6
move it back to `checkIndexedAccessIndexType`
Andarist Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only report the error on IndexedAccessType nodes
  • Loading branch information
@Andarist
Andarist committed Aug 18, 2025
commit de914f6a47826470fdb73635f782f09a75d86d35
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19584,7 +19584,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (objectType === wildcardType || indexType === wildcardType) {
return wildcardType;
}
if (isGenericObjectType(objectType)) {
if (accessNode?.kind === SyntaxKind.IndexedAccessType && isGenericObjectType(objectType)) {
const propertyName = getPropertyNameFromIndex(indexType, accessNode);
if (propertyName) {
if (someType(getApparentType(objectType), t => isNonPublicPropertyOfType(t, propertyName))) {
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/microsoft/TypeScript/pull/62300/commits/de914f6a47826470fdb73635f782f09a75d86d35

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy