gh-150258: Show relative percentage on Tachyon flamegraph#150266
Open
edvilme wants to merge 8 commits into
Open
gh-150258: Show relative percentage on Tachyon flamegraph#150266edvilme wants to merge 8 commits into
edvilme wants to merge 8 commits into
Conversation
When running profiling, users rarely care about the global percentage of the runtime. Often, they want to select a function and measure child percentages relative to that. This PR updates the flamegraph tooltips to show both "Percentage" and "Relative Percentage" when the user clicks a specific function. Fixes python#150258
…lme/cpython into tachyon-relative-percentage
scottshambaugh
left a comment
scottshambaugh
left a comment
There was a problem hiding this comment.
Tested locally and this matches what I was looking for in the issue, thanks for putting this together!
Contributor
Author
Thx for all the feedback! Glad it matches what you were looking for. I also think this will be useful! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running profiling, users rarely care about the global percentage of the runtime. Often, they want to select a function and measure child percentages relative to that.
This PR updates the flamegraph tooltips to show both "Percentage" and "Relative Percentage" when the user clicks a specific function.
Fixes #150258
Visualization
With no functions selected
With a function selected
Remarks
"Relative percentage" is only shown for the children of the selected node (<100%)