gh-103906: Avoid refcount changes for True, False, None#103907
Closed
hauntsaninja wants to merge 1 commit intopython:mainfrom
Closed
gh-103906: Avoid refcount changes for True, False, None#103907hauntsaninja wants to merge 1 commit intopython:mainfrom
hauntsaninja wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
I was literally about to open this exact same PR! 🙂 I'll just diff it with my branch and see what's different, haha. |
brandtbucher
requested changes
Apr 26, 2023
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
So, my branch has everything in this branch, except it also removes refcounts from UNARY_NOT, POP_JUMP_IF_FALSE, POP_JUMP_IF_TRUE, POP_JUMP_IF_NONE, and POP_JUMP_IF_NOT_NONE, and PyBool_FromLong.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
Member
|
See #103909 for comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.