gh-111085 Fix logic order causing nicer error to never be raised in asyncio.Timeout#110910
Closed
Gobot1234 wants to merge 4 commits intopython:mainfrom
Closed
gh-111085 Fix logic order causing nicer error to never be raised in asyncio.Timeout#110910Gobot1234 wants to merge 4 commits intopython:mainfrom
Gobot1234 wants to merge 4 commits intopython:mainfrom
Conversation
Gobot1234
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
Gobot1234
changed the title
hauntsaninja
approved these changes
Oct 18, 2023
Contributor
Author
|
@hauntsaninja does this also need an issue then? |
Member
Yeah, it's not possible to add a news entry without linking the news entry to a GitHub issue. (Or, shouldn't be possible, anyway, since the news entry is meant to be linked to an issue :p ) |
…0-19-11-40-38.gh-issue-111085.hBPpQr.rst
Gobot1234
changed the title
Eclips4
approved these changes
Oct 19, 2023
Member
Eclips4
left a comment
Eclips4
left a comment
There was a problem hiding this comment.
LGTM. Should it be backported to 3.12?
Contributor
Author
|
Turns out the bug exists on 3.11 as well |
Eclips4
added
needs backport to 3.11
Eclips4
reviewed
Oct 19, 2023
Contributor
|
I think this probably should not be backported. This effectively just changes a bad error message to a good one and has a chance of breaking code, so doesn't feel like good cost benefit. Thanks again, I see Serhiy self requested review, so will wait for that before merging. |
hauntsaninja
removed
needs backport to 3.11
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 20, 2023
asyncio.TaskGroup and asyncio.Timeout classes now raise proper RuntimeError if they are improperly used. * When they are used without entering the context manager. * When they are used after finishing. * When the context manager is entered more than once (simultaneously or sequentially). * If there is no current task when entering the context manager. They are now left in consistent state after raising an exception, so following operations can be correctly performed (if they are allowed).
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 20, 2023
asyncio.TaskGroup and asyncio.Timeout classes now raise proper RuntimeError if they are improperly used. * When they are used without entering the context manager. * When they are used after finishing. * When the context manager is entered more than once (simultaneously or sequentially). * If there is no current task when entering the context manager. They are now left in consistent state after raising an exception, so following operations can be correctly performed (if they are allowed). Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 20, 2023
asyncio.TaskGroup and asyncio.Timeout classes now raise proper RuntimeError if they are improperly used. * When they are used without entering the context manager. * When they are used after finishing. * When the context manager is entered more than once (simultaneously or sequentially). * If there is no current task when entering the context manager. They are now left in consistent state after raising an exception, so following operations can be correctly performed (if they are allowed). Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Contributor
Author
|
Closing in favour of #111111 |
Member
|
While this change fixes an AttributeError in In any case, thank you for your contribution. I included your changes in the other PR and added you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this needs a news entry or an issue