gh-111159: Fix SyntaxError doctests for non-builtin exception classes#111541
Merged
iritkatriel merged 6 commits intopython:mainfrom Nov 4, 2023
Merged
gh-111159: Fix SyntaxError doctests for non-builtin exception classes#111541iritkatriel merged 6 commits intopython:mainfrom
SyntaxError doctests for non-builtin exception classes#111541iritkatriel merged 6 commits intopython:mainfrom
Conversation
scoder
approved these changes
Oct 31, 2023
Contributor
scoder
left a comment
scoder
left a comment
There was a problem hiding this comment.
Looks almost good to me, just a performance+readability remark.
Co-authored-by: scoder <stefan_ml@behnel.de>
sobolevn
commented
Nov 1, 2023
Contributor
|
Looks good now. |
iritkatriel
approved these changes
Nov 4, 2023
iritkatriel
added
type-bug
|
Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2023
… classes (pythonGH-111541) (cherry picked from commit 18c9548) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2023
… classes (pythonGH-111541) (cherry picked from commit 18c9548) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-111732 is a backport of this pull request to the 3.12 branch. |
|
GH-111733 is a backport of this pull request to the 3.11 branch. |
Member
Author
|
Thanks everyone! 👍 |
iritkatriel
pushed a commit
that referenced
this pull request
Nov 4, 2023
iritkatriel
pushed a commit
that referenced
this pull request
Nov 4, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctestfails to compare tracebacks with notes #111159