Content-Length: 519347 | pFad | https://github.com/python/cpython/issues/125730

720 gh-125669: Do not run `-ugui` tests by default on `make test` by sobolevn · Pull Request #125730 · python/cpython · GitHub
Skip to content

gh-125669: Do not run -ugui tests by default on make test#125730

Merged
sobolevn merged 7 commits intopython:mainfrom
sobolevn:issue-125669
Oct 30, 2024
Merged

gh-125669: Do not run -ugui tests by default on make test#125730
sobolevn merged 7 commits intopython:mainfrom
sobolevn:issue-125669

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 19, 2024 •
edited by bedevere-app bot
Loading

Basically this PR changes how --fast-ci is defined and also disables gui tests with it. Because make tests spawns a lot of gui windows locally and distrurb the development workflow.

Most likely this won't affect any buildbots (if they correctly use --slow-ci). But, correct me if I am wrong.

Regular make test run now:

» make test
+ ./python.exe -u -W default -bb -E -m test --fast-ci --timeout= --dont-add-python-opts
== resources: all,-cpu,-gui

With TESTOPTS="-u gui" (or EXTRATESTOPS) passed:

» make test TESTOPTS="-u gui"
+ ./python.exe -u -W default -bb -E -m test --fast-ci --timeout= -u gui --dont-add-python-opts
== resources: all,-cpu

@sobolevn sobolevn requested review from a team, ezio-melotti and hugovk as code owners October 19, 2024 13:58
@bedevere-app bedevere-app bot mentioned this pull request Oct 19, 2024
Closed
@vstinner
Copy link
Member

vstinner commented Oct 19, 2024

Most likely this won't affect any buildbots (if they correctly use --slow-ci). But, correct me if I am wrong.

Unix buildbots run make buildbottest which uses --slow-ci. Windows buildbots run Tools\buildbot\test.bat which also uses --slow-ci.

Basically this PR changes how --fast-ci is defined and also disables gui tests with it. Because make tests spawns a lot of gui windows locally and distrurb the development workflow.

Why not only changing the make test command rather than changing the --fast-ci option for everybody? You should be able to pass -u -gui to make test.

@vstinner
Copy link
Member

vstinner commented Oct 19, 2024 •
edited by hugovk
Loading

Something like:

diff --git a/Makefile.pre.in b/Makefile.pre.in
index fb6f22d5739..20621257575 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -2097,7 +2097,7 @@ cleantest: all
 # Similar to buildbottest, but use --fast-ci option, instead of --slow-ci.
 .PHONY: test
 test: all
-       $(TESTRUNNER) --fast-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)
+       $(TESTRUNNER) --fast-ci -u-gui --timeout=$(TESTTIMEOUT) $(TESTOPTS)
 
 # Run the test suite for both architectures in a Universal build on OSX.
 # Must be run on an Intel box.

@vstinner
Copy link
Member

vstinner commented Oct 19, 2024

See also the doc: https://docs.python.org/dev/using/configure.html#make-test

vstinner
vstinner reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NEWS entry in the Tests category.

vstinner
vstinner reviewed Oct 21, 2024
View reviewed changes
vstinner
vstinner reviewed Oct 29, 2024
View reviewed changes
@sobolevn sobolevn requested a review from corona10 as a code owner October 30, 2024 09:27
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 30, 2024

CI master @hugovk, are you ok with this PR?

vstinner
vstinner reviewed Oct 30, 2024
View reviewed changes
vstinner
vstinner reviewed Oct 30, 2024
View reviewed changes
PCbuild/rt.bat Outdated
set qmode=
set dashO=
set regrtestargs=--fast-ci
set regrtestargs=--fast-ci -u-gui
Copy link
Member

@vstinner vstinner Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildbots run Tools/buildbot/test.bat which runs PCbuild/rt.bat. I'm not sure that this change is correct. Maybe it will disable GUI tests on buildbots.

Copy link
Member Author

@sobolevn sobolevn Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for this question. I was not also sure about that. Since I don't ever use windows and not quite sure about how it should work. I will revert this.

vstinner
vstinner approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the different updates.

hugovk
hugovk approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI master @hugovk, are you ok with this PR?

Looks good, thanks all! 👍

@sobolevn sobolevn merged commit 1f16df4 into python:main Oct 30, 2024
@sobolevn
Copy link
Member Author

sobolevn commented Oct 30, 2024

Thanks everyone! 👏

@warsaw
Copy link
Member

warsaw commented Oct 30, 2024

Thanks for fixing this! One ask:

I don't think that we should backport this change

Please reconsider. It's painful for the 3.13 branch and changing it would be a net win.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@sobolevn @picnixz
pythongh-125669: Do not run -ugui tests by default on make test (p…
64213b2 
…ython#125730)

Adds `make ci` target for use in CI and keeping `make test` for the local development.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@sobolevn @ebonnal
pythongh-125669: Do not run -ugui tests by default on make test (p…
cc0a07f 
…ython#125730)

Adds `make ci` target for use in CI and keeping `make test` for the local development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@vstinner vstinner vstinner approved these changes

@hugovk hugovk hugovk approved these changes

@warsaw warsaw Awaiting requested review from warsaw

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @vstinner @erlend-aasland @warsaw @hugovk








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/issues/125730

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy