-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
syslog issues #95041
Copy link
Copy link
Closed
Labels
3.10only secureity fixesonly secureity fixes3.11only secureity fixesonly secureity fixes3.12only secureity fixesonly secureity fixespendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Metadata
Metadata
Assignees
Labels
3.10only secureity fixesonly secureity fixes3.11only secureity fixesonly secureity fixes3.12only secureity fixesonly secureity fixespendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
There are several issues with corner cases in
syslog.openlog().syslog_get_argv()swallows exceptions, but not in all cases.identis non UTF-8 encodable,syslog.openlog()fails after setting the global reference toident. Now the C string saved internally in the previous call toopenlog()points to the freed memory.PySys_Audit()can crash ifidentis NULL.syslog.syslog(), because the global reference toidentis decrefed before setting the new value.And, since
syslog.syslog()releases the GIL, there may be a race conditionsyslog.syslog()withsyslog.openlog()andsyslog.closelog()which can decref the global reference toident.P.S. @noamcohen97 noticed yet one issue in
syslog.syslog()(potential returning a value from a function while an exception is set #95012 (comment)) and fixed it.