Content-Length: 464481 | pFad | https://github.com/python/cpython/pull/130032

0C gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c by WolframAlph · Pull Request #130032 · python/cpython · GitHub
Skip to content

gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c#130032

Merged
iritkatriel merged 9 commits intopython:mainfrom
WolframAlph:compare-cfg
Feb 13, 2025
Merged

gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c#130032
iritkatriel merged 9 commits intopython:mainfrom
WolframAlph:compare-cfg

Conversation

@WolframAlph
Copy link
Copy Markdown
Contributor

@WolframAlph WolframAlph commented Feb 12, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 12, 2025
Open
WolframAlph
WolframAlph commented Feb 12, 2025
View reviewed changes
Comment thread Lib/test/test_compile.py
iritkatriel
iritkatriel reviewed Feb 12, 2025
View reviewed changes
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
iritkatriel
iritkatriel reviewed Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better.

Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c Outdated
Comment thread Python/flowgraph.c
@iritkatriel iritkatriel changed the title gh-126835: Move literal list & set optimization in for iter & contains test to CFG. gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c Feb 13, 2025
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 13, 2025
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 13, 2025

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit eb3abc2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 13, 2025
@iritkatriel iritkatriel merged commit 140e69c into python:main Feb 13, 2025
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 13, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x has failed when building commit 140e69c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/336/builds/6345) and take a look at the build logs.
  4. Check if the failure is related to this commit (140e69c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/336/builds/6345

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@iritkatriel iritkatriel iritkatriel approved these changes

@isidentical isidentical Awaiting requested review from isidentical

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WolframAlph @bedevere-bot @iritkatriel @Eclips4








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/130032

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy