fix(core): ErrorHandler should not rethrow an error by default (angular#13534)

DzmitryShylovich · chuckjaz · commit 1aebea52e1ac · 2017-03-10T14:44:14.000-08:00
Closes angular#14949 Closes angular#13159 Closes angular#8993
diff --git a/packages/core/src/error_handler.ts b/packages/core/src/error_handler.ts
@@ -41,12 +41,7 @@ export class ErrorHandler {
    */
   _console: Console = console;
 
-  /**
-   * @internal
-   */
-  rethrowError: boolean;
-
-  constructor(rethrowError: boolean = true) { this.rethrowError = rethrowError; }
+  constructor(private rethrowError: boolean = false) {}
 
   handleError(error: any): void {
     this._console.error(`EXCEPTION: ${this._extractMessage(error)}`);
@@ -71,8 +66,6 @@ export class ErrorHandler {
       }
     }
 
-    // We rethrow exceptions, so operations like 'bootstrap' will result in an error
-    // when an error happens. If we do not rethrow, bootstrap will always succeed.
     if (this.rethrowError) throw error;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -41,12 +41,7 @@ export class ErrorHandler {`
`41`	`41`	`*/`
`42`	`42`	`_console: Console = console;`
`43`	`43`
`44`		`- /**`
`45`		`- * @internal`
`46`		`- */`
`47`		`- rethrowError: boolean;`
`48`		`-`
`49`		`- constructor(rethrowError: boolean = true) { this.rethrowError = rethrowError; }`
	`44`	`+ constructor(private rethrowError: boolean = false) {}`
`50`	`45`
`51`	`46`	`handleError(error: any): void {`
`52`	`47`	this._console.error(`EXCEPTION: ${this._extractMessage(error)}`);
`@@ -71,8 +66,6 @@ export class ErrorHandler {`
`71`	`66`	`}`
`72`	`67`	`}`
`73`	`68`
`74`		`- // We rethrow exceptions, so operations like 'bootstrap' will result in an error`
`75`		`- // when an error happens. If we do not rethrow, bootstrap will always succeed.`
`76`	`69`	`if (this.rethrowError) throw error;`
`77`	`70`	`}`
`78`	`71`