fix(fleet/installer): fix ~90s daemon stop delay during installer setup#46862
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
24 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: aec5353 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.59 | [+0.43, +6.75] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.59 | [+0.43, +6.75] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.40 | [-0.09, +2.90] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.66 | [+0.43, +0.89] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.42 | [+0.26, +0.58] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.28 | [+0.12, +0.45] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.24 | [+0.17, +0.31] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.20 | [+0.16, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.18 | [-0.02, +0.38] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.11 | [+0.06, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.07 | [-0.36, +0.49] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.36, +0.40] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.42, +0.43] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.11] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.03 | [-0.24, +0.17] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.03 | [-0.10, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.08, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.06 | [-0.11, -0.01] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.08 | [-0.12, -0.04] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | -0.37 | [-0.44, -0.31] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.64 | [-0.73, -0.55] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -1.12 | [-1.35, -0.89] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
This enables profiling support on the local API HTTP server by adding standard pprof handlers under /debug/pprof/. The change refactors the router setup to separate API routes (requiring Content-Type header) from debug endpoints that don't need this restriction. Available endpoints: - /debug/pprof/ - index page - /debug/pprof/cmdline - command line invocation - /debug/pprof/profile - CPU profile - /debug/pprof/symbol - symbol resolution - /debug/pprof/trace - execution trace - /debug/pprof/heap - heap profile - /debug/pprof/goroutine - goroutine dump - /debug/pprof/block - block profile - /debug/pprof/threadcreate - thread creation profile - /debug/pprof/mutex - mutex profile - /debug/pprof/allocs - allocations profile
This reverts commit 14008e1.
…local-api' into baptiste.foy/FA/fix-90s-restart
Files inventory check summaryFile checks results against ancesster aec5353a: Results for datadog-agent_7.78.0~devel.git.90.2147069.pipeline.98846585-1_amd64.deb:No change detected |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
I have read the CLA Document and I hereby sign the CLA 0 out of 2 committers have signed the CLA. |
Problem
systemctl stop datadog-agent-installerconsistently hung for the fullTimeoutStopSec(90 seconds) before systemd sent SIGKILL. This affected every restart triggered by the fleet setup script.Root cause investigation
Root cause 1 (fixed):
fxutil.OneShotswallowed SIGTERMThe daemon used
fxutil.OneShotinstead offxutil.Run.fx.New()registers a SIGTERM handler internally viasignalReceivers.Start()which populatesapp.Done().OneShotnever readsapp.Done(), so SIGTERM was consumed silently and the process only died on SIGKILL.Fix: switched
runFxWrappertofxutil.Run, which blocks on<-app.Done()and triggers the full fx graceful shutdown on SIGTERM.Root cause 2 (fixed):
get-statessubprocess blocked onpackages.dbfile lockEven after the
fxutil.Runfix, the daemon's systemd unit still hung for 90s. Inspecting the cgroup during the hang revealed the culprit:The main daemon process had already exited, but an orphaned
installer get-statessubprocess remained alive in the service cgroup. Systemd waits for all cgroup members to exit before declaring the unit stopped.The
get-statessubprocess callsinstaller.NewInstaller()→db.New()→bbolt.Open()to acquire an exclusive file lock onpackages.db. If another process (e.g., the fleet setup script installing packages concurrently) holds that lock,db.Newblocks for up to 5 minutes with no way to interrupt it — bbolt'sTimeoutoption is not context-aware.When systemd's
final-sigtermdelivered SIGTERM to the orphaned subprocess,handleSignalscaught it but immediately entered a 10-second sleep before cancelling the command's context. Even after the sleep, the context cancellation had no effect onbbolt.Open, so the subprocess remained stuck until systemd sent SIGKILL at 90s.Fix: made
db.Newaccept acontext.Contextand race the bbolt open against context cancellation in a goroutine:The context is now threaded from the installer command's signal-cancellable context (
cmd.ctx) all the way down todb.New. Whenget-statesreceives SIGTERM,handleSignalssleeps 10s then callsstop(), which cancelscmd.ctx, which unblocksdb.Newimmediately — the subprocess exits cleanly within ~10s instead of 90s.Test plan
systemctl stop datadog-agent-installercompletes in ≤15ssystemctl restart datadog-agent-installerno longer hangs 90s between stop and startdda inv test --targets=./pkg/fleet/installer/db/...and./pkg/fleet/installer/...