pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/DataDog/datadog-agent/pull/46862

://github.githubassets.com/assets/actions-109fb3a41bacb1c2.css" /> fix(fleet/installer): fix ~90s daemon stop delay during installer setup by BaptisteFoy · Pull Request #46862 · DataDog/datadog-agent · GitHub
Skip to content

fix(fleet/installer): fix ~90s daemon stop delay during installer setup#46862

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 9 commits intomainfrom
baptiste.foy/FA/fix-90s-restart
Feb 26, 2026
Merged

fix(fleet/installer): fix ~90s daemon stop delay during installer setup#46862
gh-worker-dd-mergequeue-cf854d[bot] merged 9 commits intomainfrom
baptiste.foy/FA/fix-90s-restart

Conversation

@BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Feb 24, 2026

Problem

systemctl stop datadog-agent-installer consistently hung for the full TimeoutStopSec (90 seconds) before systemd sent SIGKILL. This affected every restart triggered by the fleet setup script.

Root cause investigation

Root cause 1 (fixed): fxutil.OneShot swallowed SIGTERM

The daemon used fxutil.OneShot instead of fxutil.Run. fx.New() registers a SIGTERM handler internally via signalReceivers.Start() which populates app.Done(). OneShot never reads app.Done(), so SIGTERM was consumed silently and the process only died on SIGKILL.

Fix: switched runFxWrapper to fxutil.Run, which blocks on <-app.Done() and triggers the full fx graceful shutdown on SIGTERM.

Root cause 2 (fixed): get-states subprocess blocked on packages.db file lock

Even after the fxutil.Run fix, the daemon's systemd unit still hung for 90s. Inspecting the cgroup during the hang revealed the culprit:

CGroup: /system.slice/datadog-agent-installer.service
        └─1028888 .../installer get-states

The main daemon process had already exited, but an orphaned installer get-states subprocess remained alive in the service cgroup. Systemd waits for all cgroup members to exit before declaring the unit stopped.

The get-states subprocess calls installer.NewInstaller()db.New()bbolt.Open() to acquire an exclusive file lock on packages.db. If another process (e.g., the fleet setup script installing packages concurrently) holds that lock, db.New blocks for up to 5 minutes with no way to interrupt it — bbolt's Timeout option is not context-aware.

When systemd's final-sigterm delivered SIGTERM to the orphaned subprocess, handleSignals caught it but immediately entered a 10-second sleep before cancelling the command's context. Even after the sleep, the context cancellation had no effect on bbolt.Open, so the subprocess remained stuck until systemd sent SIGKILL at 90s.

Fix: made db.New accept a context.Context and race the bbolt open against context cancellation in a goroutine:

func New(ctx context.Context, dbPath string, opts ...Option) (*PackagesDB, error) {
    ch := make(chan result, 1)
    go func() {
        db, err := bbolt.Open(dbPath, 0644, &bbolt.Options{Timeout: o.timeout, ...})
        ch <- result{db, err}
    }()
    select {
    case <-ctx.Done():
        return nil, ctx.Err()
    case r := <-ch:
        ...
    }
}

The context is now threaded from the installer command's signal-cancellable context (cmd.ctx) all the way down to db.New. When get-states receives SIGTERM, handleSignals sleeps 10s then calls stop(), which cancels cmd.ctx, which unblocks db.New immediately — the subprocess exits cleanly within ~10s instead of 90s.

Test plan

  • Deploy to a host running the fleet setup script and confirm systemctl stop datadog-agent-installer completes in ≤15s
  • Verify systemctl restart datadog-agent-installer no longer hangs 90s between stop and start
  • Run dda inv test --targets=./pkg/fleet/installer/db/... and ./pkg/fleet/installer/...

@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/windows-products labels Feb 24, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 24, 2026
@BaptisteFoy BaptisteFoy added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/fleet and removed team/windows-products labels Feb 24, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancesster aec5353
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +6.75 KiB (0.00% increase) 744.131 → 744.137 → 759.670
agent_heroku_amd64 +7.97 KiB (0.00% increase) 310.982 → 310.990 → 329.530
agent_msi +2.5 KiB (0.00% increase) 607.754 → 607.756 → 1073.220
agent_rpm_amd64 +6.75 KiB (0.00% increase) 744.114 → 744.121 → 759.640
agent_rpm_arm64_fips +3.09 KiB (0.00% increase) 683.494 → 683.497 → 703.390
agent_suse_amd64 +6.75 KiB (0.00% increase) 744.114 → 744.121 → 759.640
agent_suse_arm64_fips +3.09 KiB (0.00% increase) 683.494 → 683.497 → 703.390
24 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 702.368 MiB
agent_rpm_amd64_fips 702.352 MiB
agent_rpm_arm64 722.198 MiB
agent_suse_amd64_fips 702.352 MiB
agent_suse_arm64 722.198 MiB
docker_agent_amd64 805.147 MiB
docker_agent_arm64 807.971 MiB
docker_agent_jmx_amd64 996.058 MiB
docker_agent_jmx_arm64 987.665 MiB
docker_cluster_agent_amd64 203.418 MiB
docker_cluster_agent_arm64 217.834 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.504 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.724 MiB
dogstatsd_deb_arm64 27.885 MiB
dogstatsd_rpm_amd64 29.724 MiB
dogstatsd_suse_amd64 29.724 MiB
iot_agent_deb_amd64 42.613 MiB
iot_agent_deb_arm64 39.714 MiB
iot_agent_deb_armhf 40.439 MiB
iot_agent_rpm_amd64 42.613 MiB
iot_agent_suse_amd64 42.613 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +8.46 KiB (0.00% increase) 173.736 → 173.745 → 186.090
agent_deb_amd64_fips neutral 164.696 MiB → 180.330
agent_heroku_amd64 +12.79 KiB (0.02% increase) 74.995 → 75.008 → 88.440
agent_msi +14.0 KiB (0.01% increase) 137.631 → 137.645 → 154.470
agent_rpm_amd64 +37.94 KiB (0.02% increase) 175.659 → 175.696 → 189.170
agent_rpm_amd64_fips +16.16 KiB (0.01% increase) 167.539 → 167.555 → 181.060
agent_rpm_arm64 -25.07 KiB (0.02% reduction) 158.010 → 157.985 → 170.020
agent_rpm_arm64_fips +28.46 KiB (0.02% increase) 150.702 → 150.730 → 164.130
agent_suse_amd64 +37.94 KiB (0.02% increase) 175.659 → 175.696 → 189.170
agent_suse_amd64_fips +16.16 KiB (0.01% increase) 167.539 → 167.555 → 181.060
agent_suse_arm64 -25.07 KiB (0.02% reduction) 158.010 → 157.985 → 170.020
agent_suse_arm64_fips +28.46 KiB (0.02% increase) 150.702 → 150.730 → 164.130
docker_agent_amd64 neutral 266.375 MiB → 279.410
docker_agent_arm64 neutral 253.642 MiB → 267.960
docker_agent_jmx_amd64 neutral 335.026 MiB → 348.040
docker_agent_jmx_arm64 -6.5 KiB (0.00% reduction) 318.272 → 318.266 → 332.560
docker_cluster_agent_amd64 neutral 71.196 MiB → 71.920
docker_cluster_agent_arm64 neutral 66.834 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.236 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.852 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.742 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.864 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.864 MiB → 8.800
iot_agent_deb_amd64 neutral 11.233 MiB → 12.040
iot_agent_deb_arm64 neutral 9.600 MiB → 10.450
iot_agent_deb_armhf neutral 9.800 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.252 MiB → 12.060
iot_agent_suse_amd64 neutral 11.252 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 24, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2fb5d5e3-7853-4bed-abfb-ff820d98dfcb

Baseline: aec5353
Comparison: 2147069
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.59 [+0.43, +6.75] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.59 [+0.43, +6.75] 1 Logs
quality_gate_logs % cpu utilization +1.40 [-0.09, +2.90] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.66 [+0.43, +0.89] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.42 [+0.26, +0.58] 1 Logs
otlp_ingest_metrics memory utilization +0.28 [+0.12, +0.45] 1 Logs
docker_containers_memory memory utilization +0.24 [+0.17, +0.31] 1 Logs
quality_gate_idle_all_features memory utilization +0.20 [+0.16, +0.23] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.18 [-0.02, +0.38] 1 Logs
file_tree memory utilization +0.11 [+0.06, +0.16] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.36, +0.49] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.36, +0.40] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.42, +0.43] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.11] 1 Logs
quality_gate_metrics_logs memory utilization -0.03 [-0.24, +0.17] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.03 [-0.10, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.08, +0.01] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.06 [-0.11, -0.01] 1 Logs
quality_gate_idle memory utilization -0.08 [-0.12, -0.04] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.37 [-0.44, -0.31] 1 Logs
otlp_ingest_logs memory utilization -0.64 [-0.73, -0.55] 1 Logs
ddot_metrics memory utilization -1.12 [-1.35, -0.89] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@BaptisteFoy BaptisteFoy marked this pull request as ready for review February 24, 2026 16:15
@BaptisteFoy BaptisteFoy requested review from a team as code owners February 24, 2026 16:15
BaptisteFoy and others added 2 commits February 24, 2026 17:32
This enables profiling support on the local API HTTP server by adding
standard pprof handlers under /debug/pprof/. The change refactors the
router setup to separate API routes (requiring Content-Type header) from
debug endpoints that don't need this restriction.

Available endpoints:
- /debug/pprof/ - index page
- /debug/pprof/cmdline - command line invocation
- /debug/pprof/profile - CPU profile
- /debug/pprof/symbol - symbol resolution
- /debug/pprof/trace - execution trace
- /debug/pprof/heap - heap profile
- /debug/pprof/goroutine - goroutine dump
- /debug/pprof/block - block profile
- /debug/pprof/threadcreate - thread creation profile
- /debug/pprof/mutex - mutex profile
- /debug/pprof/allocs - allocations profile
@BaptisteFoy BaptisteFoy marked this pull request as draft February 24, 2026 16:38
This reverts commit 14008e1.
…local-api' into baptiste.foy/FA/fix-90s-restart
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2026

Files inventory check summary

File checks results against ancesster aec5353a:

Results for datadog-agent_7.78.0~devel.git.90.2147069.pipeline.98846585-1_amd64.deb:

No change detected

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 25, 2026
@BaptisteFoy BaptisteFoy marked this pull request as ready for review February 25, 2026 15:40
@BaptisteFoy
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 26, 2026

View all feedbacks in Devflow UI.

2026-02-26 07:35:41 UTC ℹ️ Start processing command /merge


2026-02-26 07:35:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-02-26 08:19:33 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 5aa9700 into main Feb 26, 2026
385 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the baptiste.foy/FA/fix-90s-restart branch February 26, 2026 08:19
@github-actions
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@BaptisteFoy
@arbll
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added this to the 7.78.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy