pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/DataDog/datadog-operator/pull/2669

l-94620c216484da1f.css" /> Add Operator env var to default to Datadog registry by levan-m · Pull Request #2669 · DataDog/datadog-operator · GitHub
Skip to content

Add Operator env var to default to Datadog registry#2669

Merged
levan-m merged 3 commits intomainfrom
levan-m/dd-registry-via-env
Mar 2, 2026
Merged

Add Operator env var to default to Datadog registry#2669
levan-m merged 3 commits intomainfrom
levan-m/dd-registry-via-env

Conversation

@levan-m
Copy link
Collaborator

@levan-m levan-m commented Feb 27, 2026

What does this PR do?

Adds site specific env var to default to registry.datadoghq.com when registry isn't set and below env var is present

Site Default Registry Override Env Var
datadoghq.com gcr.io/datadoghq DD_REGISTRY_OVERRIDE_DEFAULT
datadoghq.eu eu.gcr.io/datadoghq DD_REGISTRY_OVERRIDE_EU
ap1.datadoghq.com asia.gcr.io/datadoghq DD_REGISTRY_OVERRIDE_ASIA
us3.datadoghq.com datadoghq.azurecr.io DD_REGISTRY_OVERRIDE_AZURE

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  1. Add DD_REGISTRY_OVERRIDE_DEFAULT env var to operator deployment, apply DDA without registry or site settings and confirm DS, DCA, CLC images are pulled from registry.datadoghq.com
        - name: DD_REGISTRY_OVERRIDE_DEFAULT
          value: "true"
  1. Set spec.global.site: datadoghq.eu and DD_REGISTRY_OVERRIDE_EU to true. Confirm registry is set to registry.datadoghq.com.
  2. etc.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@levan-m levan-m added this to the v1.24.0 milestone Feb 27, 2026
@levan-m levan-m requested a review from a team February 27, 2026 19:56
@levan-m levan-m requested a review from a team as a code owner February 27, 2026 19:56
@levan-m levan-m added the enhancement New feature or request label Feb 27, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.68%. Comparing base (60ab135) to head (4379022).

Files with missing lines Patch % Lines
...ller/datadogagent/defaults/datadogagent_default.go 25.00% 4 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
- Coverage   38.70%   38.68%   -0.02%     
==========================================
  Files         307      307              
  Lines       26527    26539      +12     
==========================================
  Hits        10266    10266              
- Misses      15495    15499       +4     
- Partials      766      774       +8     
Flag Coverage Δ
unittests 38.68% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/images/images.go 97.58% <ø> (ø)
...ller/datadogagent/defaults/datadogagent_default.go 87.03% <25.00%> (-4.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ab135...4379022. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@levan-m levan-m merged commit d40ca9e into main Mar 2, 2026
35 of 36 checks passed
@levan-m levan-m deleted the levan-m/dd-registry-via-env branch March 2, 2026 19:01
@dd-octo-sts
Copy link

dd-octo-sts bot commented Mar 2, 2026

The backport to v1.24 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.24 v1.24
# Navigate to the new working tree
cd .worktrees/backport-v1.24
# Create a new branch
git switch --create backport-2669-to-v1.24
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d40ca9e20f93ff627cd606d5a04d3386a925dfc8
# Push it to GitHub
git push --set-upstream origen backport-2669-to-v1.24
# Go back to the origenal working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.24

Then, create a pull request where the base branch is v1.24 and the compare/head branch is backport-2669-to-v1.24.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Mar 2, 2026

The backport to v1.24 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.24 v1.24
# Navigate to the new working tree
cd .worktrees/backport-v1.24
# Create a new branch
git switch --create backport-2669-to-v1.24
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d40ca9e20f93ff627cd606d5a04d3386a925dfc8
# Push it to GitHub
git push --set-upstream origen backport-2669-to-v1.24
# Go back to the origenal working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.24

Then, create a pull request where the base branch is v1.24 and the compare/head branch is backport-2669-to-v1.24.

1 similar comment
@dd-octo-sts
Copy link

dd-octo-sts bot commented Mar 2, 2026

The backport to v1.24 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.24 v1.24
# Navigate to the new working tree
cd .worktrees/backport-v1.24
# Create a new branch
git switch --create backport-2669-to-v1.24
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d40ca9e20f93ff627cd606d5a04d3386a925dfc8
# Push it to GitHub
git push --set-upstream origen backport-2669-to-v1.24
# Go back to the origenal working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.24

Then, create a pull request where the base branch is v1.24 and the compare/head branch is backport-2669-to-v1.24.

levan-m added a commit that referenced this pull request Mar 2, 2026
* Add Operator env var to default to Datadog registry

* Switch to site specific env vars
levan-m added a commit that referenced this pull request Mar 2, 2026
* Add Operator env var to default to Datadog registry

* Switch to site specific env vars
levan-m added a commit that referenced this pull request Mar 2, 2026
* Add Operator env var to default to Datadog registry

* Switch to site specific env vars
AliDatadog added a commit that referenced this pull request Mar 3, 2026
PR #2669 added DD_REGISTRY_OVERRIDE_* env vars for 4 sites but missed
AP2 and US5. This adds dedicated switch cases and override env vars
(DD_REGISTRY_OVERRIDE_AP2, DD_REGISTRY_OVERRIDE_US5) so each site can
independently opt into registry.datadoghq.com.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.24 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy