Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
2768769 to
924af1a
Compare
kata_containers/tests/test_unit.py
Outdated
There was a problem hiding this comment.
suggestion: I see that there are only two tests that actually invoke the check using dd_run_check, I recommend adding more such tests that cover most use cases (metrics collection and tagging) and few error paths (unreachable endpoints, configuration error, ...) to make sure the integration behaves as expected.
There was a problem hiding this comment.
Sure ! I am planning to change the tests as soon as I have a POC ready in an experimental cluster
Co-authored-by: nubtron <49084+nubtron@users.noreply.github.com>
8b68f12 to
cf6710c
Compare
What does this PR do?
Integrating kata container
Motivation
Team requirements
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged