Fixes #14461: Avatar stats don't update after another user uses a buffing abililty #14920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a first time contributor so the workflow for tests hasn't run automatically. Please may an admin start it? 👉👈 |
|
Hello, I'm just leaving a comment again because it's been a while. |
|
I've tried to run this locally and haven't been able to. Here's the error message I got when I ran
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14461
Party members' state wasn't always being updated when casting spells.
If the spell is is a bulk spell (
bulk: true), the state would not update when the spell is cast. The state was being updated during casting inwebsite\common\script\content\spells.jsuntil bulk spells were introduced in #14544.Changes
Updates the
partyMembersstate using the updated data returned by thecastAPI callin the
castEnd()method inwebsite\client\src\mixins\spells.jsrather than relying on each spell'scastmethod in the common scripts to update it.UUID: 00cfc368-4bf7-4d50-8100-6e3f21707e10