don’t use body with delete

HabitRPG · phillipthelen · May 13, 2025 · May 13, 2025 · May 29, 2025 · May 13, 2025
commit f33e256b573792a53efaef6588e1d3a231fe9a03
diff --git a/website/client/src/store/actions/hall.js b/website/client/src/store/actions/hall.js
@@ -40,10 +40,7 @@ export async function getHeroGroupPlans (store, payload) {
 }
 
 export async function deleteHero (store, payload) {
-  const url = `/api/v4/members/${payload.uuid}`;
-  const response = await axios.delete(url, {
-    deleteAccount: payload.deleteHabiticaAccount,
-    deleteAmplitude: payload.deleteAmplitudeData,
-  });
+  const url = `/api/v4/members/${payload.uuid}?deleteAccount=${payload.deleteAccount}&deleteAmplitude=${payload.deleteAmplitude}`;
+  const response = await axios.delete(url);
   return response.data.data;
 }
diff --git a/website/server/controllers/api-v4/members.js b/website/server/controllers/api-v4/members.js
@@ -44,15 +44,15 @@ api.deleteMember = {
   url: '/members/:memberId',
   async handler (req, res) {
     req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
-    req.checkBody('deleteAccount').optional().isIn(['true', 'false']);
-    req.checkBody('deleteAmplitude').optional().isIn(['true', 'false']);
+    req.checkQuery('deleteAccount').optional().isIn(['true', 'false']);
+    req.checkQuery('deleteAmplitude').optional().isIn(['true', 'false']);
     const validationErrors = req.validationErrors();
     if (validationErrors) throw validationErrors;
     sendJob('delete-user', {
       data: {
         userId: req.params.memberId,
-        deleteAccount: req.body.deleteAccount === 'true',
-        deleteAmplitude: req.body.deleteAmplitude === 'true',
+        deleteAccount: req.query.deleteAccount === 'true',
+        deleteAmplitude: req.query.deleteAmplitude === 'true',
       },
     });
     res.respond(200, {});