Handle PROTOCOL_CANCELLED (state 3) in _dispatch_result.#1283
Draft
mnbbrown wants to merge 1 commit intoMagicStack:masterfrom
Draft
Handle PROTOCOL_CANCELLED (state 3) in _dispatch_result.#1283mnbbrown wants to merge 1 commit intoMagicStack:masterfrom
mnbbrown wants to merge 1 commit intoMagicStack:masterfrom
Conversation
Prior to this patch the state machine did not handle results arriving after cancellation. This add explicit support for that scenario by keeping track of the state prior the cancellation (cancelled_from_state), and using cancelled_from_state when consuming the results. The alternative option is just silently dropping the results (similar to PROTOCOL_TERMINATING).
Author
|
Upon reflection I'm not sure this is the best approach.. it would possibly leave a connection in a state that's unexpected by the client. Needs further thought. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch the state machine did not handle results arriving
after cancellation. This add explicit support for that scenario by
keeping track of the state prior to cancellation
(cancelled_from_state), and using cancelled_from_state when consuming the
results.
The alternative option is just silently dropping the results (similar to
PROTOCOL_TERMINATING).
Would maybe close #490