Conversation
Member
Author
|
@metamaskbot preview-build |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
7 tasks
ffmcgee725
reviewed
Mar 20, 2026
| notifications = []; | ||
| } | ||
|
|
||
| const sortedAccounts = sortAccountIdsByLastSelected |
Member
There was a problem hiding this comment.
[nit] this name can be misleading, since we are not always sorting these accounts, sortedAccounts could actually be unsorted if sortAccountIdsByLastSelected is not provided.
we could name the function param caipAccountIds, and this variable accounts for example (open to other suggestions)
Member
Author
There was a problem hiding this comment.
fair point. I've actually had to move this sorting to a different helper based on a bug that cursorbot caught. Mind reviewing again and seeing if you still feel the function param name change still makes sense?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/chain-agnostic-permission/src/operators/caip-permission-operator-session-scopes.ts
Outdated
Show resolved
Hide resolved
wenfix
previously approved these changes
Mar 20, 2026
… into jl/sortAccountIdsByLastSelected
adonesky1
reviewed
Mar 23, 2026
adonesky1
reviewed
Mar 23, 2026
packages/multichain-api-middleware/src/handlers/wallet-getSession.ts
Outdated
Show resolved
Hide resolved
Contributor
|
|
Co-authored-by: Alex Donesky <adonesky@gmail.com>
…ion.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
Member
Author
|
yeah, let's sort them. There are places in extension where we do not need to sort, but i agree that it makes sense to sort them here |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
## @metamask/chain-agnostic-permissions ## [1.5.0] ### Added - Add optional `sortAccountIdsByLastSelected` parameter to `getSessionScopes` function to enable custom account ordering within session scopes ([#8255](#8255)) ### Changed - Bump `@metamask/permission-controller` from `^12.2.0` to `^12.2.1` ([#8225](#8225)) - Bump `@metamask/controller-utils` from `^11.17.0` to `^11.19.0` ([#7583](#7583), [#7995](#7995)) ## @metamask/multichain-api-middleware ## [2.0.0] ### Added - **BREAKING:** Add required `sortAccountIdsByLastSelected` hook to `wallet_getSession`, `wallet_createSession`, and `wallet_invokeMethod` handlers to enable custom account ordering in session scopes ([#8255](#8255)) ### Changed - Bump `@metamask/permission-controller` from `^12.2.0` to `^12.2.1` ([#8225](#8225)) - Bump `@metamask/json-rpc-engine` from `^10.2.2` to `^10.2.3` ([#8078](#8078)) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily a release/version bump, but it includes a major version bump for `@metamask/multichain-api-middleware` and updated dependency constraints that may break downstream consumers expecting the previous API contract. > > **Overview** > Bumps the monorepo version to `880.0.0` and publishes new package versions: `@metamask/chain-agnostic-permission` `1.5.0` and **breaking** `@metamask/multichain-api-middleware` `2.0.0`. > > Updates dependent packages (notably `@metamask/eip1193-permission-middleware` and `@metamask/multichain-api-middleware`) to require `@metamask/chain-agnostic-permission@^1.5.0`, and refreshes associated changelog entries and `yarn.lock` mappings. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 879c9d7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/chain-agnostic-permissionsortAccountIdsByLastSelectedparameter togetSessionScopesfunction(accounts: CaipAccountId[]) => CaipAccountId[]accountsarray within each scope (both required and optional scopes)@metamask/multichain-api-middlewaresortAccountIdsByLastSelectedhook towallet_getSessionhandlergetSessionScopeswhen building session responsesortAccountIdsByLastSelectedhook towallet_createSessionhandlergetSessionScopeswhen building session scopes for approvalReferences
See: MetaMask/metamask-extension#41068
Checklist
Note
Medium Risk
Medium risk because it changes handler hook contracts in
multichain-api-middleware(breaking for integrators) and alters ordering of accounts returned in session scopes, which could impact downstream UI/logic expectations.Overview
Adds an optional
sortAccountIdsByLastSelectedhook to@metamask/chain-agnostic-permissiongetSessionScopes, applying it to theaccountslist for every merged scope before returning session scopes.Updates
wallet_getSession,wallet_createSession, andwallet_invokeMethodhandlers in@metamask/multichain-api-middlewareto require and pass through this new sorting hook, with corresponding test updates and changelog entries noting the breaking hook requirement.Written by Cursor Bugbot for commit 4fc3d03. This will update automatically on new commits. Configure here.