Playwright tests with POM #2547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-Object-Models consist of each page as an object, centralized in a Page Manager, with tests containing abstractions of commands. banner.spec.ts and interface-language-is-stickey.spec.ts contain refactorizations of previous tests (and also keep the old ones).
Page-Object-Models consist of each page as an object, centralized in a Page Manager, with tests containing abstractions of commands. banner.spec.ts and interface-language-is-stickey.spec.ts contain refactorizations of previous tests (and also keep the old ones).
This is a diplicate that I need to create a diff for a PR
…c-35148/essential-playwright-tests-infra-onboarding
…ntial-playwright-tests-infra-onboarding
…nt to consolidate them
Playwright infra readme Created a README with instructions on how to build new tests.
…ility functions in tests
schreibersefaria
commented
Aug 4, 2025
e2e-tests/utils.ts
Outdated
| return page; | ||
| // Use a persistent auth file to store/reuse login state | ||
| let page: Page; | ||
| if (fs.existsSync(AUTH_FILE)) { |
There was a problem hiding this comment.
Won't this break on changing the admin/non admin user?
…r both logged in/logged out state
…nterruptingMessageOverlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request for a Cauldron.
This branch introduces POM architecture into Playwright tests and adds tests.
All test are passing on a Cauldron