Open
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There seems to be two bugs when running
`d8 cli.js -- --test <subset>`:
1. A typo in cli.js (`cliParams.get("tests")` should've been
`cliParams.get("test")`) which leads to
```
cli.js:122: TypeError: Cannot read properties of undefined (reading 'split')
let tests = cliParams.has("test") ? cliParams.get("tests").split(",") : []
^
TypeError: Cannot read properties of undefined (reading 'split')
at cli.js:122:63
```
2. performance.mark/performance.measure in d8 requires PerformanceMark
objects as arguments and do not take mark name strings.
```
console.error: JetStream3 failed: Error: Invalid 'startMark' argument: Not an Object
console.error: Error: Invalid 'startMark' argument: Not an Object
at Driver.start (./JetStreamDriver.js:352:25)
at async runJetStream (cli.js:135:9)
cli.js:141: Error: Invalid 'startMark' argument: Not an Object
```
This patch fixes the typo in 1. For 2, since these are only used for
UI annotations, replace them with no-ops in d8 instead.
joyeecheung
force-pushed
the
fix-d8-test
branch
from
c1db8c7 to
917279b
Compare
| performance.measure ??= function(){}; | ||
|
|
||
| if (isD8) { | ||
| performance.mark = function(){}; |
Contributor
There was a problem hiding this comment.
Mark and measure is supported in newer d8 versions (we do run CI tests so this does work). What d8 version were you using?
|
|
||
| if (cliArgs.length) { | ||
| let tests = cliParams.has("test") ? cliParams.get("tests").split(",") : [] | ||
| let tests = cliParams.has("test") ? cliParams.get("test").split(",") : [] |
Contributor
There was a problem hiding this comment.
Could you add a shell test as well to https://github.com/WebKit/JetStream/blob/main/tests/run-shell.mjs so we don't accidentally regress this again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seem to be two bugs when running
d8 cli.js -- --test <subset>:cliParams.get("tests")should've beencliParams.get("test")) which leads toThis patch fixes the typo in 1. For 2, since these are only used for UI annotations, replace them with no-ops in d8 instead.
cc @camillobruni