[iOS debug] http/wpt/navigation-api/scroll-behavior/manual-scroll-reload.html is a flaky text failure#60805
Open
Conversation
…oad.html is a flaky text failure rdar://172757985 https://bugs.webkit.org/show_bug.cgi?id=310111 Reviewed by NOBODY (OOPS!). This test is flakily failing since scroll position is reported as 0 instead of 8. The issue is that scroll positions do not settle in time on (slow) debug builds due to overlapping async scroll updates through the scrolling coordinator. Fix in manual-scroll-reload.html: - Add rAF before navigate_event.scroll() so that the scroll anchoring from buffer.remove() can settle in the UI process. - Add rAF after navigate_event.scroll() so that the scroll-to-fragment can settle in the UI process before asserting. * LayoutTests/http/wpt/navigation-api/scroll-behavior/manual-scroll-reload.html: * LayoutTests/platform/ios/TestExpectations:
Collaborator
|
EWS run on current version of this PR (hash eaf86ba) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eaf86ba
eaf86ba