pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/WebKit/WebKit/pull/60809

assets/global-68dd150ce6c8e711.css" /> REGRESSION(290430@main): Timelines recording stops on page reload even when auto-stop is disabled by rcaliman-apple · Pull Request #60809 · WebKit/WebKit · GitHub
Skip to content

REGRESSION(290430@main): Timelines recording stops on page reload even when auto-stop is disabled#60809

Open
rcaliman-apple wants to merge 1 commit intoWebKit:mainfrom
rcaliman-apple:eng/REGRESSION-290430-main-Timelines-recording-stops-on-page-reload-even-when-auto-stop-is-disabled
Open

REGRESSION(290430@main): Timelines recording stops on page reload even when auto-stop is disabled#60809
rcaliman-apple wants to merge 1 commit intoWebKit:mainfrom
rcaliman-apple:eng/REGRESSION-290430-main-Timelines-recording-stops-on-page-reload-even-when-auto-stop-is-disabled

Conversation

@rcaliman-apple
Copy link
Contributor

@rcaliman-apple rcaliman-apple commented Mar 17, 2026

18ceef0

REGRESSION(290430@main): Timelines recording stops on page reload even when auto-stop is disabled
https://bugs.webkit.org/show_bug.cgi?id=310137
rdar://169732727

Reviewed by NOBODY (OOPS!).

290430@main split `InspectorTimelineAgent` into `PageTimelineAgent` and
`WorkerTimelineAgent`. When `mainFrameStartedLoading()` was moved to
`PageTimelineAgent`, the `if (m_tracking) return;` guard was dropped.

This guard prevents the backend from dispatching `Timeline.autoCaptureStarted`
to the frontend when a recording is already active. Without it, every page reload
or navigation during an active recording causes `WI.TimelineManager.prototype.autoCaptureStarted()`
on the frontend to unconditionally stop the current recording and start a new one,
regardless of the "Stop recording once page loads" setting.

This patch restores the guard so that `PageTimelineAgent::mainFrameStartedLoading()`
is a no-op when instruments are already recording.

* Source/WebCore/inspector/agents/page/PageTimelineAgent.cpp:
(WebCore::PageTimelineAgent::mainFrameStartedLoading):

18ceef0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

…n when auto-stop is disabled

https://bugs.webkit.org/show_bug.cgi?id=310137
rdar://169732727

Reviewed by NOBODY (OOPS!).

290430@main split `InspectorTimelineAgent` into `PageTimelineAgent` and
`WorkerTimelineAgent`. When `mainFrameStartedLoading()` was moved to
`PageTimelineAgent`, the `if (m_tracking) return;` guard was dropped.

This guard prevents the backend from dispatching `Timeline.autoCaptureStarted`
to the frontend when a recording is already active. Without it, every page reload
or navigation during an active recording causes `WI.TimelineManager.prototype.autoCaptureStarted()`
on the frontend to unconditionally stop the current recording and start a new one,
regardless of the "Stop recording once page loads" setting.

This patch restores the guard so that `PageTimelineAgent::mainFrameStartedLoading()`
is a no-op when instruments are already recording.

* Source/WebCore/inspector/agents/page/PageTimelineAgent.cpp:
(WebCore::PageTimelineAgent::mainFrameStartedLoading):
@rcaliman-apple rcaliman-apple added the Web Inspector Bugs related to the WebKit Web Inspector. label Mar 17, 2026
Copy link
Member

@dcrousso dcrousso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks for fixing this

can we write a test for this scenario in case something like this happens again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy