REGRESSION(290430@main): Timelines recording stops on page reload even when auto-stop is disabled#60809
Open
Conversation
…n when auto-stop is disabled https://bugs.webkit.org/show_bug.cgi?id=310137 rdar://169732727 Reviewed by NOBODY (OOPS!). 290430@main split `InspectorTimelineAgent` into `PageTimelineAgent` and `WorkerTimelineAgent`. When `mainFrameStartedLoading()` was moved to `PageTimelineAgent`, the `if (m_tracking) return;` guard was dropped. This guard prevents the backend from dispatching `Timeline.autoCaptureStarted` to the frontend when a recording is already active. Without it, every page reload or navigation during an active recording causes `WI.TimelineManager.prototype.autoCaptureStarted()` on the frontend to unconditionally stop the current recording and start a new one, regardless of the "Stop recording once page loads" setting. This patch restores the guard so that `PageTimelineAgent::mainFrameStartedLoading()` is a no-op when instruments are already recording. * Source/WebCore/inspector/agents/page/PageTimelineAgent.cpp: (WebCore::PageTimelineAgent::mainFrameStartedLoading):
Collaborator
|
EWS run on current version of this PR (hash 18ceef0) Details |
dcrousso
approved these changes
Mar 18, 2026
Member
dcrousso
left a comment
There was a problem hiding this comment.
oops thanks for fixing this
can we write a test for this scenario in case something like this happens again?
burg
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
18ceef0
18ceef0