[JSC] Nested using blocks lose outer disposals#60820
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 18, 2026
Merged
[JSC] Nested using blocks lose outer disposals#60820webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash 0eb25a1) Details |
Constellation
approved these changes
Mar 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=310116 Reviewed by Yusuke Suzuki. emitUsingBodyScope holds a reference into m_usingScopeStack across the emitBody call that may recursively append. Once nesting exceeds the initial Vector capacity, the append reallocates and the stale reference reads a moved-from UsingScope whose slots vector is empty, so the finally emits no dispose calls for those outer blocks. ASAN catches the freed read directly. Test: JSTests/stress/nested-using-blocks.js * JSTests/stress/nested-using-blocks.js: Added. (shouldBe): (eval.string_appeared_here.string_appeared_here.repeat.depth.1.string_appeared_here.string_appeared_here.repeat): (shouldBe.async then): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: Canonical link: https://commits.webkit.org/309457@main
0eb25a1 to
57a48c3
Compare
Collaborator
|
Committed 309457@main (57a48c3): https://commits.webkit.org/309457@main Reviewed commits have been landed. Closing PR #60820 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
57a48c3
0eb25a1
🛠 win🧪 win-tests